Project

General

Profile

Actions

Feature #37250

closed

How can we improve the javascript tests

Added by dosas please_edit_me 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

so that errors like this https://projects.theforeman.org/issues/37245 do not go unnoticed for 2 months.

The problem here is probably two fold:
1. It is an integration issue: The changes that broke the tests were introduced in foreman.
2. The javascript tests only run https://github.com/theforeman/foreman_ansible/blob/master/.github/workflows/js_tests.yml when there are changes to webpack or package.json

To fix 1: it might make sense to have a nightly/weekly test runs on the default branch that runs all js and ruby tests

Actions #1

Updated by The Foreman Bot 8 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_ansible/pull/700 added
Actions #2

Updated by The Foreman Bot 8 months ago

  • Pull request deleted (https://github.com/theforeman/foreman_ansible/pull/700)
Actions #3

Updated by Evgeni Golov 8 months ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF