Bug #37290: Hostgroup inheritance for LCE and CV does not work for grandchildren hostgroups - Katello - Foreman

Actions

Copy link

Bug #37290

open

Hostgroup inheritance for LCE and CV does not work for grandchildren hostgroups

Added by Nadja Heitmann 9 months ago. Updated 28 days ago.

Status:

New

Priority:

Normal

Assignee:

Category:

Hosts

Target version:

Katello 4.16.0

Difficulty:

Triaged:

Yes

Bugzilla link:

Pull request:

Fixed in Releases:

Found in Releases:

Katello 4.14.0

Red Hat JIRA:

Description

1) create a hostgroup 'parent' with LCE and CV
2) create a child hostgroup 'child' and choose 'parent' as as parent hostgroup

It takes the correct values from 'parent' for LCE and CV, but does not add 'Inherit parent (...)'

Change LCE and CV to something new

3) create a grandchild hostgroup 'grandchild' and choose 'child' as parent hostgroup

CV and LCE are taken from 'parent' hostgroup rather than from 'child' hostgroup

In my opinion, there are multiple thing that are going wrong here:
1) https://github.com/Katello/katello/blob/master/app/helpers/katello/hosts_and_hostgroups_helper.rb#L134 and https://github.com/Katello/katello/blob/master/app/helpers/katello/hosts_and_hostgroups_helper.rb#L163 methods do not pick the `Inherit parent (...)` option, it is added to the beginning of the list only
2) The parent host group is not resolved correctly for CV and LCE. This can either be a UI problem during saving of the new hostgroup or a problem that is hidden deeper.

Actions

Copy link

Updated by Jeremy Lenz 9 months ago

Status changed from New to Need more information

Hi Nadja

We've had a lot of improvements in the hostgroup area lately. Does this issue also occur on nightly / master ?

Actions

Copy link

Updated by Nadja Heitmann 9 months ago

Found in Releases Katello 4.14.0 added
Found in Releases deleted (~~Katello 4.11.1~~)

Actions

Copy link

Updated by Nadja Heitmann 9 months ago

Jeremy Lenz wrote in #note-1:

We've had a lot of improvements in the hostgroup area lately. Does this issue also occur on nightly / master ?

Hi Jeremy,
thanks for the feedback. I have tested on a nightly Forklift and there is the same problem. I cannot pin down why the inherited CL/LCE is not resolved correctly for grandchildren.

Actions

Copy link

Updated by Samir Jha 9 months ago

Status changed from Need more information to New
Target version set to Katello 4.13.0
Triaged changed from No to Yes

Actions

Copy link

Updated by Samir Jha 9 months ago

Category set to Hosts

Actions

Copy link

Updated by Partha Aji 8 months ago

https://projects.theforeman.org/issues/37290#note-3

Hey Nadja,

While I am able to reproduce 2 i.e.

2) create a child hostgroup 'child' and choose 'parent' as as parent hostgroup
It takes the correct values from 'parent' for LCE and CV, but does not add 'Inherit parent (...)'
Change LCE and CV to something new

I am not able to reproduce 3

3) create a grandchild hostgroup 'grandchild' and choose 'child' as parent hostgroup
CV and LCE are taken from 'parent' hostgroup rather than from 'child' hostgroup

It clearly shows me the child hostgroups LCE and CV for the grandchild.
We can try to resolve the inherit but I dont think the other is a problem.

Can you please verify again.

Actions

Copy link

Updated by Nadja Heitmann 8 months ago

Hey Partha, thanks a lot for testing. I tried again, and indeed, it is exactly as you describe. Looks like there was an issue on my nightly Forklift deploy, sorry for that!

2) create a child hostgroup 'child' and choose 'parent' as as parent hostgroup
It takes the correct values from 'parent' for LCE and CV, but does not add 'Inherit parent (...)'
Change LCE and CV to something new

This is a minor issue then, I would say. Would be nice to fix though to have the UI consistent.

Actions

Copy link