Feature #3751
closedAdd id='new' to all buttons/links that create new objects
Description
QE would like to request that every button/link responsible for creating new objects (i.e. Environments, Users, Roles, OS, etc) have a id='new' attribute for easier locating UI elements during automation.
Updated by Og Maciel almost 11 years ago
Should have also added "Delete/Edit/Cancel/Yes/No" to that list
Updated by Ohad Levy almost 11 years ago
- Status changed from New to Feedback
rails generate that ID by default to all forms, for example, a new domain would have id=new_domain, editing a domain would have id=edit_domain_<numberical_id>
Updated by Ohad Levy almost 11 years ago
- Status changed from Feedback to New
oh, i didnt read it right, you were not only talking about the form, reopening.
Updated by Lukas Zapletal almost 11 years ago
- Status changed from New to Assigned
- Assignee set to Lukas Zapletal
Taking.
Updated by Anonymous almost 11 years ago
- Target version changed from 1.9.3 to 1.9.2
Updated by Dominic Cleal almost 11 years ago
- Status changed from Assigned to New
- Assignee deleted (
Lukas Zapletal)
Updated by Lukas Zapletal almost 11 years ago
- Status changed from New to Ready For Testing
- Assignee set to Lukas Zapletal
- Difficulty set to trivial
https://github.com/theforeman/foreman/pull/1146
Og please test this patch if it works for you. Should cover most cases.
Updated by Og Maciel almost 11 years ago
Lukas, I applied this patch and restarted foreman. Then I tried to create a new operating system via the web ui. The New Operating system button had the following markup:
<div class="btn-toolbar pull-right"> <a class="btn btn-success" href="/operatingsystems/new"></a> </div>
I clicked it and then looked at the source for the Cancel and Submit buttons:
<form id="new_operatingsystem" class="form-horizontal well" method="post" action="/operatingsystems" accept-charset="UTF-8"> <div class="fr close-button"></div> <div style="margin:0;padding:0;display:inline"></div> <ul class="nav nav-tabs" data-tabs="tabs"></ul> <div class="tab-content"></div> <div class="form-actions"> <a class="btn btn-default two-pane-close" href="/operatingsystems"></a> <input class="btn btn-primary" type="submit" value="Submit" name="commit"></input> </div> </form>
I expected to see unique IDs for the buttons but that doesn't seem to be working for this page. To be clear then, I see that the form has a unique ID but not the buttons. Is this the intention with the patch?
Updated by Og Maciel almost 11 years ago
ok, so I missed one part of the patch. Once that was fixed I did get a ID for the submit buttons but after talking to Lukaz, he will also try to add IDs to more types of buttons (e.g. Cancel, Yes, No, etc)
Updated by Anonymous almost 11 years ago
- Target version changed from 1.9.2 to 1.9.1
Updated by Dominic Cleal over 10 years ago
- Translation missing: en.field_release set to 4
Updated by Lukas Zapletal over 10 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset bfee97b6a6980b6ad4f5bd65f4b60680f08967f5.
Updated by Dominic Cleal over 10 years ago
- Related to Bug #4441: Overriden 'link_to' is protected and breaks expected use pattern added
Updated by Dominic Cleal about 9 years ago
- Related to Bug #11828: Undefined method 'split' for nil:NilClass traceback when accessing /about added