Actions
Bug #37613
closedReport renderer tests fail depending on the libyaml version
Difficulty:
Triaged:
Yes
Description
different libyaml versions encode nil
slightly differently:
libyaml-0.1.7 (EL8):
irb(main):001:0> require 'yaml' => true irb(main):002:0> {"lol":nil}.to_yaml => "---\n:lol: \n"
libyaml-0.2.5 (EL9):
irb(main):001:0> require 'yaml' => true irb(main):002:0> {"lol":nil}.to_yaml => "---\n:lol:\n"
Both are valid documents and both are parsed fine back with both libyaml versions.
However, this breaks our tests:
Failure: ReportScopeTest::#report_render#test_0005_render types [test/unit/foreman/renderer/scope/report_test.rb:107] Minitest::Assertion: --- expected +++ actual @@ -7,5 +7,5 @@ Number: 1 Bool: false Empty: '' - Nil: + Nil: "
(if you look closely, the one line is "Nil: " and the other "Nil:")
Updated by The Foreman Bot 5 months ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/10230 added
Updated by Evgeni Golov 5 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|7b1d442d3ce9d847374d244e626c085d233bac8c.
Updated by The Foreman Bot 4 months ago
- Pull request https://github.com/theforeman/foreman/pull/10249 added
Updated by Evgeni Golov 4 months ago
- Fixed in Releases 3.11.1 added
- Fixed in Releases deleted (
3.11.2)
Updated by Ewoud Kohl van Wijngaarden 3 months ago
- Triaged changed from No to Yes
Updated by The Foreman Bot 2 months ago
- Pull request https://github.com/theforeman/foreman/pull/10314 added
Actions