Bug #38329: Avoid string building with << which breaks with frozen strings - Foreman

Actions

Copy link

Bug #38329

closed

Avoid string building with << which breaks with frozen strings

Added by Ewoud Kohl van Wijngaarden 29 days ago. Updated 19 days ago.

Status:

Closed

Priority:

Normal

Assignee:

Ewoud Kohl van Wijngaarden

Category:

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/10502

Fixed in Releases:

3.15.0

Found in Releases:

Red Hat JIRA:

Description

When dealing with frozen strings, << breaks. Using += unfreezes the string and is thus safer.

[1] pry(main)> msg = 'x'.freeze
=> "x" 
[2] pry(main)> msg.frozen?
=> true
[3] pry(main)> msg << 'y'
FrozenError: can't modify frozen String: "x" (FrozenError)
from (pry):3:in `__pry__'
[4] pry(main)> msg += 'y'
=> "xy" 
[5] pry(main)> msg.frozen?
=> false