Actions
Bug #38688
closed
Provisioning templates use host_enc macro to determine the realm
Status:
Closed
Priority:
Normal
Assignee:
Category:
Unattended installations
Target version:
-
Difficulty:
Triaged:
No
Description
The provisioning templates use some variation of:
if host_enc['parameters']['realm'] && @host.realm
This requires the full ENC to be rendered for no good reason: the realm parameter is equivalent to @host.realm&.name (https://github.com/theforeman/foreman/blob/c28ab6ff1cd0b8fe77b853a5bfbd70ef86508af9/app/models/host_info_providers/static_info.rb#L54-L55). Since name is mandatory and we already check for @host.realm anyway we can drop the redundant check.
Updated by The Foreman Bot 5 months ago
- Status changed from New to Ready For Testing
- Assignee set to Ewoud Kohl van Wijngaarden
- Pull request https://github.com/theforeman/foreman/pull/10659 added
Updated by Ewoud Kohl van Wijngaarden 5 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|5eb81b1cf66a1c93ec51e040e92af35dafd0f04c.
Updated by The Foreman Bot 5 months ago
- Pull request https://github.com/theforeman/foreman/pull/10670 added
Actions