Project

General

Custom queries

Profile

Actions
Copy link

Bug #3869

closed

API error messages poorly formatted

Added by Thomas McKay over 11 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Daniel Lobato Garcia
Category:
API
Target version:
1.4.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

GET /api/users with an unauthorized user returns in the json below. Note the missing 'results' keyword.

{
"total": 0,
"subtotal": 0,
"page": 1,
"per_page": 20,
"search": null,
"sort": {
"by": null,
"order": null
},
"": {
"message": "Access denied",
"details": null
}
}

Related issues 3 (1 open — 2 closed)

Related to Foreman - Feature #3011: default root name for api json index response to :results but make it configurableClosedJoseph Magen09/02/2013Actions
Related to Hammer CLI - Bug #4190: Fix error handling to match the updated api formatClosedDaniel Lobato Garcia01/27/2014Actions
Related to Foreman - Bug #4315: Hosts power management API doesn't return standard error responsesNewActions
Actions
Copy link
 #4

Updated by Daniel Lobato Garcia over 11 years ago

Should we go for this? It seems to me that 403 is meaningful enough for the client not to even try to read 'results'.

Actions
Copy link
 #5

Updated by Dominic Cleal over 11 years ago

Daniel Lobato Garcia wrote:

Should we go for this? It seems to me that 403 is meaningful enough for the client not to even try to read 'results'.

I think so, because the message is valuable too for the reason, the client should be able to access it.

Actions
Copy link
 #12

Updated by Dominic Cleal about 11 years ago

  • Status changed from Ready For Testing to Closed
  • Translation missing: en.field_release set to 2

Seems I put the wrong redmine number in the commit message (incorrectly #3960).

This was fixed in 0f7d219a4a65cd795eecd05117b08511d9025de2.

Actions
Copy link

Also available in: Atom PDF