Project

General

Profile

Bug #3900

Class removed because invalid syntax validation

Added by Andrei Burd almost 8 years ago. Updated about 5 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Puppet integration
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

Hi!
I recently made the following change in the manifest:
nginx::server { 'repo':
listen_port => '7897',
- sname => "repo",
+ sname => "repo repo-${downcase(::location)}.rvzr.net",
docroot => '/var/repo'
}

That lead to deleting the class from the class as as I understood because of validation problems, but puppet applied everything ok.
and because of Bug #2394 it did delete class from one of the hosts that lead to produstion issues.


Related issues

Related to Foreman - Feature #7086: Puppet modules being skipped or failed to import should be reported or noticed by foreman.New2014-08-14
Related to Foreman - Bug #11661: Puppet importer class should return a warning when a class is defined twiceNew2015-09-02
Related to Smart Proxy - Feature #15095: Add Puppet server environment_classes API supportClosed
Related to Smart Proxy - Bug #2289: smart-proxy should warn when it cannot read some puppet module file or directoryResolved2013-03-07
Has duplicate Foreman - Bug #9052: Foreman/foreman-proxy don't report classes skipped due to syntax error during import from Puppet.Duplicate2015-01-20
Has duplicate Foreman - Feature #11393: Class importer should present useful errorsDuplicate2015-08-17

History

#1 Updated by Dominic Cleal almost 8 years ago

  • Category set to Puppet integration
  • Legacy Backlogs Release (now unused) deleted (1)

#2 Updated by Dominic Cleal over 7 years ago

  • Related to Feature #7086: Puppet modules being skipped or failed to import should be reported or noticed by foreman. added

#3 Updated by Dominic Cleal almost 7 years ago

  • Has duplicate Bug #9052: Foreman/foreman-proxy don't report classes skipped due to syntax error during import from Puppet. added

#4 Updated by Dominic Cleal over 6 years ago

  • Has duplicate Feature #11393: Class importer should present useful errors added

#5 Updated by Dominic Cleal about 6 years ago

  • Related to Bug #11661: Puppet importer class should return a warning when a class is defined twice added

#6 Updated by Dominic Cleal over 5 years ago

  • Related to Feature #15095: Add Puppet server environment_classes API support added

#7 Updated by Dominic Cleal over 5 years ago

  • Related to Bug #2289: smart-proxy should warn when it cannot read some puppet module file or directory added

#8 Updated by Dominic Cleal about 5 years ago

#15095 provides a smart proxy API with the error information, however #7086 should probably be implemented first to make use of it.

Implementing this may need some memorising of which class was imported from where, so when a syntax error occurs it can skip classes originally imported from the file with the error.

Also available in: Atom PDF