Project

General

Profile

Actions
Copy link

Bug #39091

closed

Structured APT migration rake task not marked as applied if there are no deb repos during upgrade

Added by Quirin Pamp 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Quirin Pamp
Category:
-
Target version:
Katello 4.20.0
Difficulty:
trivial
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/11646
Fixed in Releases:
Katello 4.20.0, Katello 4.21.0
Found in Releases:
Katello 4.19.0
Red Hat JIRA:

Description

lib/katello/tasks/upgrades/4.19/enable_structured_apt_for_deb.rake is run as part of upgrades via foreman-rake upgrade:run

However, if there are no deb repos, we exit the rake task early using exit, and the last_run_time is not set in the upgrade_tasks table.

This means post upgrade checks complain that there are pending upgrade tasks, which they determine using:

SELECT name FROM upgrade_tasks WHERE last_run_time IS NULL;

We need to use "next" instead of "exit"!

Actions
Copy link
 #1

Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/11646 added
Actions
Copy link
 #2

Updated by The Foreman Bot 5 months ago

  • Fixed in Releases Katello 4.21.0 added
Actions
Copy link
 #3

Updated by Quirin Pamp 5 months ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #4

Updated by Vladimir Sedmik 5 months ago

  • Triaged changed from No to Yes
Actions
Copy link
 #5

Updated by The Foreman Bot 5 months ago

  • Fixed in Releases Katello 4.20.0 added
Actions
Copy link

Also available in: Atom PDF