Plugins » Katello

Description of problem:

automatic_content_count_updates Setting should disable Capsule's automated content stats recalculation. Yet the `::Actions::Katello::CapsuleContent::UpdateContentCounts` task is triggered at the end of `Actions::Katello::OrphanCleanup::RemoveOrphans` task, regardless of the settings value.

How reproducible:

100%

Is this issue a regression from an earlier version:

No

Steps to Reproduce:

1. Have an external Capsule

2. Set `automatic_content_count_updates=false`

3. Launch orphan cleanup (`foreman-rake katello:delete_orphaned_content`)

4. Check what tasks are triggered.

Actual behavior:
Remove Orphans task is triggered for each Capsule.

Update Content Counts is triggered for each external Capsule as well.

Expected behavior:
No Update Content Counts (until automatic_content_count_updates is reset to True)

Business Impact / Additional info:

I will create a PR with the fix. Simply, `app/lib/actions/katello/orphan_cleanup/remove_orphans.rb` needs to run finalize phase conditionally.