Actions
Bug #39165
closedFix of #38972 could make existing Foreman environment doesn't work
Description
As discussed in PR conversation1, fix2 of #38972 could make existing Foreman environment doesn't work if user sets both IP address and FQDN of target BMC.
Discussion with colleague concludes that priority of IP address & FQDN set by user should be changed to 'IP address -> FQDN' with following reason:
- If user specifies both IP address and FQDN, it's natural for IP address to take precedence. If user expects name resolution of FQDN through DNS, they may only specify FQDN. It's fair assumption that user expects IP address is used when user specifies IP address along with FQDN.
In addition to above reason, making IP address higher precedence over FQDN doesn't affect existing Foreman user environment.
[1] https://github.com/theforeman/foreman/pull/10842#issuecomment-4003496506
[2] https://github.com/theforeman/foreman/pull/10842
Updated by The Foreman Bot 4 months ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/10913 added
Updated by Anonymous 4 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|7e84f2312b159088cb0754bb8d09110e7022fd3d.
Actions