Project

General

Profile

Actions

Feature #39298

closed

Use bulk insert for new fact values on persisted hosts

Added by Pablo Méndez Hernández 5 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Fixed in Releases:
Found in Releases:

Description

FactImporter#add_new_facts currently inserts each new fact individually via create! inside a loop. Replace with a single insert_all for persisted hosts, reducing DB round-trips by ~94% (108 INSERTs to 6). Compose/parent facts (nil values from StructuredFactImporter) are excluded from bulk insert and handled individually to preserve per-fact error handling.

Actions #1

Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/10979 added
Actions #2

Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman/pull/10980 added
Actions #3

Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 5.0.0 added
Actions #4

Updated by Anonymous 4 months ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by Ewoud Kohl van Wijngaarden 3 months ago

  • Red Hat JIRA set to SAT-45132
Actions

Also available in: Atom PDF