Project

General

Profile

Actions

Bug #39301

open

Identify LED operations do not support LocationIndicatorActive, failing on BMCs where IndicatorLED is deprecated

Added by Yusuke Hirota about 1 month ago. Updated about 1 month ago.

Status:
Ready For Testing
Priority:
Normal
Assignee:
Category:
BMC
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

Summary

Current identify LED implementation only supports IndicatorLED, which is deprecated in the Redfish specification. BMCs that exclusively expose LocationIndicatorActive cannot perform identify LED operations.

Description

The Redfish specification has deprecated the IndicatorLED property in favor of LocationIndicatorActive (boolean: true / false).

According to the DMTF Redfish Specification DSP0268 2025.2 (p.310):

The state of the indicator LED, which identifies the chassis.
This property shall contain the indicator light state for the indicator light associated with this system.
Deprecated in v1.14 and later. This property has been deprecated in favor of the LocationIndicatorActive property.

The current implementation relies solely on IndicatorLED for identifystatus, identifyon, and identifyoff. On BMCs with newer firmware that only expose LocationIndicatorActive and no longer provide IndicatorLED, the following issues occur:

  • Identify status retrieval does not work correctly
  • Identify LED on/off operations fail

Steps to Reproduce

  1. Prepare a BMC that only supports LocationIndicatorActive and does not expose IndicatorLED
  2. Execute the chassis identify-on command via API: curl -u 'USER:PASSWORD' -X GET 'http://<Smart-Proxy-FQDN>:8000/bmc/<BMC_ADDRESS>/chassis/identify/on?bmc_provider=redfish'
  3. Observe the indicator LED state on the target chassis

Actual Behavior

Since the IndicatorLED property does not exist in the BMC response, identify status retrieval fails and identify LED on/off operations do not work.

Expected Behavior

  • When LocationIndicatorActive is present, it should be used preferentially for identify LED operations
  • When LocationIndicatorActive is absent, the implementation should fall back to IndicatorLED
  • This ensures identify LED functionality works correctly on both newer and older BMC implementations
Actions #1

Updated by Yusuke Hirota about 1 month ago

  • Project changed from Foreman to Smart Proxy
  • Category changed from BMC to BMC
Actions #2

Updated by The Foreman Bot about 1 month ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/940 added
Actions

Also available in: Atom PDF