Actions
Refactor #4032
closedTFTP orchestration uses direct object comparison
Description
It shouldn't. This was the root cause of why the TFTP orchestration was working for the last year - the build? flag was never read correctly, but because old.os != os was always returning true (even when the OS wasn't changed) the TFTP orchestration was working.
We've fixed the problem in build? (PR 1159) but the object comparisons remain. You can prove that Rails does odd things with a smple snippet:
u = User.first
reload!
u1 = User.first
u == u1
=> false
As a start I've altered the TFTP orchestration to use object.id which is reliable (since it's loaded from the db). There are probably a lot more of these around the codebase though...
Updated by Greg Sutcliffe almost 11 years ago
Updated by Greg Sutcliffe almost 11 years ago
- Related to Bug #4031: TFTP record is not updated after host is built added
Updated by Dominic Cleal almost 11 years ago
- Translation missing: en.field_release set to 2
Updated by Greg Sutcliffe almost 11 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 409ce13e71b5a23178e109b0fb240fc2e2c6ff94.
Actions