Project

General

Profile

Bug #4234

Cannot edit host's puppet parameters

Added by Alexandre Barth about 5 years ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
Host creation
Target version:
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

I try to override puppet class parameters, when i submit modifications they are not recorded. It works if i use Matcher Value in Puppet Class view. I don't see anything in foreman logs even in debug mode.


Related issues

Related to Foreman - Bug #4227: Override Parameter not saved in HostDuplicate2014-01-30

Associated revisions

Revision 130f301a (diff)
Added by Stephen Benjamin about 5 years ago

fixes #4234 - cannot edit host's puppet parameters

Revision a6ab0522 (diff)
Added by Stephen Benjamin about 5 years ago

fixes #4234 - cannot edit host's puppet parameters

(cherry picked from commit 130f301a508ae31549145e5fa9b176f42dc20995)

History

#1 Updated by Alexandre Barth about 5 years ago

New information : if i create a new host named foo, in puppet classes smart class parameter, it adds the matcher fqdn=foo instead of fqdn=foo.domain. If i add the domain to the matcher when i edit the host values are then overrided.

#2 Updated by Alexandre Barth about 5 years ago

So i solved the problem providing fqdn as name instead of shortname when creating a new host. Isn't this useless as we must provide domain in network tab ?
And when i edit the host after creation, display name is the shortname ... maybe caus i use the use_shortname_for_vms setting

#3 Updated by Dominic Cleal about 5 years ago

  • Category set to Host creation
  • Legacy Backlogs Release (now unused) deleted (2)

Probably unrelated to the VM setting, pretty sure that only affects the compute resource.

#4 Updated by Alexandre Barth about 5 years ago

i'm using a vmware compute resource.

#5 Updated by Dominic Cleal about 5 years ago

  • Related to Bug #4227: Override Parameter not saved in Host added

#7 Updated by Dominic Cleal about 5 years ago

Confirmed that restoring the line fixes #4227. I suspect though adding it here might lead to multiple errors being added (line 777), and we need to check the other code above it is OK with being run multiple times.

#8 Updated by Stephen Benjamin about 5 years ago

What do you think about providing an fqdn getter to ensure we always return an fqdn?

Like this:
https://github.com/stbenjam/foreman/compare/4234-override-host-parameters

Figured I'd ask before opening the PR to see if you had a better idea in mind.

#9 Updated by Dominic Cleal about 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Stephen Benjamin
  • Target version set to 1.9.2
  • Legacy Backlogs Release (now unused) set to 5

#10 Updated by Dmitri Dolguikh about 5 years ago

  • Target version changed from 1.9.2 to 1.9.1

#11 Updated by Anonymous about 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF