Bug #5158
closed
- Triaged changed from No to Yes
- Translation missing: en.field_release set to 86
As of this comment, I see the following instances still:
vagrant@katello-devel katello (master)$ grep -r attr_accessible app/
app/models/katello/concerns/smart_proxy_extensions.rb: attr_accessible :lifecycle_environment_ids
app/models/katello/concerns/container_extensions.rb: attr_accessible :capsule_id
app/models/katello/concerns/organization_extensions.rb: attr_accessible :label
The models that extend foreman will continue to use attr_accessible while foreman uses protected attributes. When they change to strong parameters, we will be able to remove those attr_accessible calls
From reviewing the Rails 4 PR, was attr_accessible only needed when those parameters were set via a create or update_attributes call? Could we change where those variables are assigned to the block/direct method to remove these?
They are mostly through create or update_attributes afaik, but would have to look closer to be sure. Is there a benefit to setting them directly vs. using attr_accessible?
- Status changed from New to Closed
Decided to close for now. It's not an issue unless foreman drops protected attributes and hopefully they will notify us before doing so.
- Status changed from Closed to Duplicate
- Is duplicate of Feature #15741: Use parameter_filter instead of attr_accessible added
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by