Project

General

Profile

Bug #5209

Negative timeout config value causes errors

Added by Tomáš Strachota over 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Foreman commands (obsolete)
Target version:
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Our example config file advises to use -1 for infinite timeouts.
https://github.com/theforeman/hammer-cli-foreman/blob/master/config/foreman.yml#L10

This can cause "time interval must be positive (ArgumentError)" exception on some ruby versions.
According to the docs the solution seems to be using 0 instead of -1.
http://ruby-doc.org/stdlib-1.9.3/libdoc/timeout/rdoc/Timeout.html#method-c-timeout

We should change our sample config and check values < 0 before the timeout is set.

Associated revisions

Revision 337cba41 (diff)
Added by Tomas Strachota over 5 years ago

FIxes #5209 - negative timeout config value causes errors

Revision 8b0c2294
Added by Tomas Strachota over 5 years ago

Merge pull request #113 from tstrachota/timeout_docs

FIxes #5209 - negative timeout config value causes errors

Revision e89ff889 (diff)
Added by Tomas Strachota over 5 years ago

Fixes #5209 - setting infinite timeouts

Revision f18c41cd
Added by Tomas Strachota over 5 years ago

Merge pull request #114 from tstrachota/timeout_docs

Fixes #5209 - setting infinite timeouts

History

#1 Updated by Tomáš Strachota over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomáš Strachota
  • Target version set to 1.8.4

#2 Updated by Dmitri Dolguikh over 5 years ago

  • Target version changed from 1.8.4 to 1.8.3

#3 Updated by Dmitri Dolguikh over 5 years ago

  • Target version changed from 1.8.3 to 1.8.4

#4 Updated by Dmitri Dolguikh over 5 years ago

  • Target version changed from 1.8.4 to 1.8.3

#5 Updated by Anonymous over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Applied in changeset hammer-cli-foreman|commit:337cba41bbb5c6472bf1c557367deff48d2da589.

#6 Updated by Tomáš Strachota over 5 years ago

  • Status changed from Closed to Ready For Testing

Re-opening as I found some issues with different versions of rest-client:
https://github.com/theforeman/hammer-cli-foreman/pull/114

#7 Updated by Anonymous over 5 years ago

  • Status changed from Ready For Testing to Closed

Applied in changeset hammer-cli-foreman|commit:e89ff88932a1ff37bf436b36175fbaa35ea7f2d0.

Also available in: Atom PDF