Project

General

Profile

Bug #5247

Smart Class parameters cannot be overridden in nested host groups

Added by Martin Jackson about 5 years ago. Updated 10 months ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Puppet integration
Target version:
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Running the 1.5.0RC1 with puppet 3.5.1 from puppetlabs.

I have three hostgroups:

base
base/nullmailer
base/nullmailer/foreman

I have the foreman's puppet class applied to base, and am overriding puppet::server to "false". I can see the value set in base. I also have puppet::server_git_repo overridden to "true".

I do not see those variables in either base/nullmailer or in base/nullmailer/foreman.

I know some organizations depend greatly on parameter inheritance, so I am setting the priority to "High".

I can provide logs etc. if needed.

Associated revisions

Revision 4c8d2c2c (diff)
Added by Dominic Cleal about 5 years ago

fixes #5247 - overridable keys displayed on host group when env is inherited

Revision 673c886b (diff)
Added by Dominic Cleal almost 5 years ago

fixes #5247 - overridable keys displayed on host group when env is inherited

(cherry picked from commit 4c8d2c2ccde0ea04a493004382d14d5030cb6d9a)

History

#1 Updated by Martin Jackson about 5 years ago

Note: The title should read "nested hostgroups", sorry.

#2 Updated by Dominic Cleal about 5 years ago

  • Subject changed from Smart Class parameters cannot be overridden in nested classes to Smart Class parameters cannot be overridden in nested host groups
  • Category set to Puppet integration
  • Status changed from New to Ready For Testing
  • Assignee set to Dominic Cleal
  • Target version set to 1.8.4
  • Legacy Backlogs Release (now unused) set to 4

https://github.com/theforeman/foreman/pull/1394

This seems to occur when the environment on the child host group has an inherited environment ("Inherit parent (production)"). Explicitly set environments, or the above patch should resolve it. Thanks!

#3 Updated by Martin Jackson about 5 years ago

Tested and working. I could see and override values in nested hostgroups.

#4 Updated by Dominic Cleal about 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF