Project

General

Profile

Actions

Feature #5368

closed

Bastion: replace function declarations with function expressions

Added by Mike McCune almost 11 years ago. Updated over 6 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

From https://github.com/Katello/katello/pull/3805/files#r10587210

Best practices are to use function expressions instead of declarations. We are using function declarations as success and error callbacks mainly.

We should also document this in the readme file.

See also: http://javascriptweblog.wordpress.com/2010/07/06/function-declarations-vs-function-expressions/
----
Imported from https://trello.com/c/UFjU3xw4/382-bastion-replace-function-declarations-with-function-expressions_

Actions #1

Updated by Eric Helms about 10 years ago

  • Status changed from New to Rejected
  • Triaged set to Yes
Actions #2

Updated by Eric Helms almost 9 years ago

  • Translation missing: en.field_release set to 166
Actions

Also available in: Atom PDF