Project

General

Profile

Bug #5574

CDN path verification should handle redirects

Added by Justin Sherrill about 8 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Orchestration
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Currently the cdn_var_substitutor#valid_substitutions? treats 301 redirects as an error. In some cases it will try to fetch $REPO_URL/repodata which causes a redirect to $REPO_URL/repodata/. One solution is to have it request $REPO_URL/repodata/repomd.xml, but i would argue it should just follow redirects as well.

Associated revisions

Revision 68149256 (diff)
Added by Ivan Necas about 8 years ago

Fixes #5574 - consider 301 as correct response for the cdn path

But check for `repodata/` instead of `repodata` as that's what we want
in the first place.

Revision ca930f2d
Added by Ivan Necas about 8 years ago

Merge pull request #4156 from iNecas/1099221

Fixes #5574 - consider 301 as correct response for the cdn path

History

#1 Updated by Justin Sherrill about 8 years ago

To temporarily patch the issue:

/opt/rh/ruby193/root/usr/share/gems/gems/katello-1.5.0/app/lib/katello/util/cdn_var_substitutor.rb

Line 116:

 Change:
        is_valid = valid_path?(real_path, 'repodata') || valid_path?(real_path, 'PULP_MANIFEST')
 To:

        is_valid = valid_path?(real_path, 'repodata/repomd.xml') || valid_path?(real_path, 'PULP_MANIFEST')

#2 Updated by Mike McCune about 8 years ago

  • Due date set to 05/22/2014
  • Assignee set to Mike McCune
  • Target version set to 44
  • Triaged changed from No to Yes

#3 Updated by Ivan Necas about 8 years ago

  • Status changed from New to Assigned
  • Assignee changed from Mike McCune to Ivan Necas
  • Bugzilla link set to https://bugzilla.redhat.com/show_bug.cgi?id=1099221

#4 Updated by Ivan Necas about 8 years ago

  • Status changed from Assigned to Ready For Testing

#5 Updated by Ivan Necas about 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Applied in changeset katello|commit:68149256f311f3426c60b7dc73f0f69dda96368a.

#6 Updated by Eric Helms almost 8 years ago

  • Legacy Backlogs Release (now unused) set to 13

Also available in: Atom PDF