Project

General

Profile

Bug #565

"rake puppet:import:puppet_classes" not detecting changes properly

Added by Marcello de Sousa over 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Importers
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Example how to reproduce it:

PuppetEnvironment:

[production]
modulepath=/etc/puppet/environments/production/modules

Copy a module (mysql for ex.) from another environment (master) to the "production" env:

cd /etc/puppet/environments/production/modules

cp -a /etc/puppet/environments/master/modules/mysql ./mysql

Try running the rake task:

rake puppet:import:puppet_classes RAILS_ENV=production

(in /usr/share/foreman)
Evaluating possible changes to your installation
No changes detected

And in foreman we don't get the module available in the production environment .
The web interface also doesn't see the change
( https://foreman.test.bluedome.local/puppetclasses/import_environments )


Related issues

Related to Foreman - Feature #756: Foreman doesn't see puppet environment's modulepath changes until restartClosed2011-03-17

Associated revisions

Revision bb9a1ad1 (diff)
Added by Paul Kelly about 8 years ago

Fixes #565 - rake puppet:import:puppet_classes misses some changes

Signed-off-by: Paul Kelly <>

Revision 5b6d1303 (diff)
Added by Ohad Levy about 8 years ago

fixes typo in log output - refs #565

History

#1 Updated by Marcello de Sousa over 8 years ago

I noticed that, if I "destroy" in foreman a class or an environment and run the rake task again, it then detect and import the changes described above but it won't report them:

1- destroy a class via GUI
2- rake puppet:import:puppet_classes RAILS_ENV=production

Evaluating possible changes to your installation
Scheduled changes to your environment
New      environments  :
Obsolete environments  :
New      puppetclasses : apache2
Obsolete puppetclasses :

3- "apache2" is re-inported as well as the new "mysql" module/classes (not reported)

#2 Updated by Paul Kelly over 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee changed from Ohad Levy to Paul Kelly
  • Branch set to bug/565-import-puppet_classes-wrong

Just rewrote the whole thing.

#3 Updated by Ohad Levy over 8 years ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Ohad Levy over 8 years ago

  • Status changed from Closed to Ready For Testing

oops, closed by mistake, reopening

#5 Updated by Paul Kelly over 8 years ago

rebased
retested
repushed

#6 Updated by Paul Kelly about 8 years ago

rebased
retested
repushed

#7 Updated by Paul Kelly about 8 years ago

rebased
retested
repushed

#8 Updated by Paul Kelly about 8 years ago

  • Status changed from Ready For Testing to Need more information

Ohad, You say that you experienced some problems with this patch. Something about an eval that failed. Could you provide more information? Maybe the log showing the http call?

#9 Updated by Marcello de Sousa about 8 years ago

Hi, I've installed today the latest Foreman from the develop branch and still having similar problems as in the description of this issue.
It still doesn't detect changes properly with both the script and the Web interface.

#10 Updated by Paul Kelly about 8 years ago

rebased, retested and pushed.
Maybe these minor mods have fixed the issue but I think not.
Ohad if you can reproduce your eval failures I would like to look at your logs :-) I have repeatedly added the example42 database, in various ways, and have had no problems.

#11 Updated by Paul Kelly about 8 years ago

  • Status changed from Need more information to Ready For Testing
  • % Done changed from 0 to 100

#12 Updated by Ohad Levy about 8 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF