Project

General

Profile

Bug #5841

Foreman dashboard slow in 1.5 for non admin users

Added by Chuck Schweizer over 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Performance
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Previous ticket that fixed the issue for foreman 1.4
http://projects.theforeman.org/issues/3122
http://projects.theforeman.org/issues/2982

This foreman instance has 25,036 puppet clients reporting to it.

foreman_slow_non_admin_dashboard.txt foreman_slow_non_admin_dashboard.txt 348 KB debug output Chuck Schweizer, 05/20/2014 07:21 PM

Related issues

Related to Foreman - Bug #2982: Non Admin user Dashboard load is very slow with a large number of mangaged nodesResolved2013-08-28
Related to Foreman - Bug #3122: when fact filters are added to a user, error column reference "id" is ambiguous for dashboard and fact_valuesClosed2013-09-19
Related to Foreman - Bug #7009: N+1 hosts query in dashboard pageClosed2014-08-10
Related to Foreman - Bug #8817: PGError: ERROR: missing FROM-clause entry for table "hostgroups"Closed2014-12-31

Associated revisions

Revision d50c7990 (diff)
Added by Dominic Cleal almost 5 years ago

fixes #5841 - use inner query when retrieving reports for subset of authorised hosts

Revision ecdb85a8 (diff)
Added by Dominic Cleal almost 5 years ago

fixes #5841 - use inner query when retrieving reports for subset of authorised hosts

(cherry picked from commit d50c79908831be65da0b0005e438c9e819db613a)

History

#1 Updated by Dominic Cleal over 5 years ago

  • Related to Bug #2982: Non Admin user Dashboard load is very slow with a large number of mangaged nodes added

#2 Updated by Dominic Cleal over 5 years ago

  • Related to Bug #3122: when fact filters are added to a user, error column reference "id" is ambiguous for dashboard and fact_values added

#3 Updated by Dominic Cleal over 5 years ago

  • Difficulty deleted (easy)

#4 Updated by Ohad Levy over 5 years ago

Dominic, did you investigate on this? Any reason why the ID's are added instead of INNER query?

#5 Updated by Dominic Cleal over 5 years ago

Ohad Levy wrote:

Dominic, did you investigate on this? Any reason why the ID's are added instead of INNER query?

Not in depth, but I saw here that it was done deliberately: https://github.com/theforeman/foreman/blob/develop/app/models/report.rb#L36-L37

It might be we can use the authorized scope directly, but I haven't tested.

#6 Updated by Dominic Cleal about 5 years ago

  • Related to Bug #7009: N+1 hosts query in dashboard page added

#7 Updated by Dominic Cleal almost 5 years ago

  • Status changed from New to Assigned
  • Assignee set to Dominic Cleal

#8 Updated by The Foreman Bot almost 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1995 added
  • Pull request deleted ()

#9 Updated by Dominic Cleal almost 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#10 Updated by Dominic Cleal almost 5 years ago

  • Legacy Backlogs Release (now unused) set to 29

#11 Updated by Dominic Cleal over 4 years ago

  • Related to Bug #8817: PGError: ERROR: missing FROM-clause entry for table "hostgroups" added

#12 Updated by Dominic Cleal over 4 years ago

This was shipped in 1.7.1 but will be reverted in 1.7.3 as it caused a more severe issue recorded in #8817. The change remains in the 1.8/1.9 branches, where I hope to have a better solution to fix both.

Also available in: Atom PDF