Project

General

Custom queries

Profile

Actions
Copy link

Refactor #5936

closed

Unnecessary call to FactName.maximum slows down ENC

Added by Daniel Lobato Garcia almost 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Daniel Lobato Garcia
Category:
External Nodes
Target version:
1.5.1
Difficulty:
Triaged:
Bugzilla link:
1107671
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

As explained here: https://github.com/theforeman/foreman/pull/1477

The query "SELECT MAX AS maximum_id, name AS name FROM `fact_names` GROUP BY name ORDER BY fact_names.name" needs to be called only when there are facts to create. Calling it every time slows down every ENC call, especially when the fact_names table is large.

#1

Updated by Dominic Cleal almost 11 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100
  • Translation missing: en.field_release set to 16
#2

Updated by Bryan Kearney almost 11 years ago

  • Bugzilla link set to https://bugzilla.redhat.com/show_bug.cgi?id=1107671
Actions
Copy link

Also available in: Atom PDF