Project

General

Profile

Refactor #6187

Dynflowize environment delete

Added by Ivan Necas almost 5 years ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Orchestration
Target version:
Branch:
Difficulty:
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Related issues

Related to Katello - Bug #6815: I can delete a environment even if it has associationsRejected2014-07-29
Blocks Katello - Feature #6180: Implement org destroyClosed2014-06-12

Associated revisions

Revision c7bfc159 (diff)
Added by Partha Aji over 4 years ago

Fixes #6815,#6187/bz1125398,1125358 - Environment Destroy Dynflow

This commit adds code to orchestrate lifecycle env destroy via dynflow.
In addition to that it adds code to prevent environment deletion if any
of the lifecycle env associations like content hosts and activation keys

Revision 26e6f173 (diff)
Added by Adam Ruzicka over 4 years ago

Fixes #6187,BZ1125358 - Deleting a resource and creation a new one wont lead to conflicts

History

#1 Updated by Ivan Necas almost 5 years ago

#2 Updated by David Davis almost 5 years ago

  • Assignee set to David Davis

#3 Updated by David Davis over 4 years ago

  • Status changed from New to Closed

The env destroy doesn't require dynflow. It doesn't touch any backend services. There was some code I wrote/fixed as part of this bug but I'll just move that code to the PR for #6180.

#4 Updated by Ivan Necas over 4 years ago

  • Status changed from Closed to New
  • Target version deleted (48)

I don't think this is reason for not having the lifecycle enevironment destroy action. Two reasons for having it:

1. destroying the resoruces under the lifecycle environment: consumers, content view versions

2. having the action recorded in the foreman tasks for auditing purposes

#5 Updated by Ivan Necas over 4 years ago

  • Target version set to 54

#6 Updated by David Davis over 4 years ago

@ivan, content view versions and consumers aren't tied directly to environments. I'll have to take a look at the code again but I don't believe you can delete an environment if it has content_view_environments.

#7 Updated by David Davis over 4 years ago

Looks like I wrote the code in an another PR but forgot to pull it over to the new PR:

https://github.com/Katello/katello/pull/4324/files#diff-186d05e79248a368ffb5ff36269a9ea2R39

#8 Updated by David Davis over 4 years ago

I've created a bug to address the deleting of environments with associations in the short term.

Longer term, maybe we can develop something that would at least warn users if environments have content hosts, etc. This would of course rely on dynflow. Maybe we could even allow users to choose whether to reassign or destroy associations like the content view remove code.

#9 Updated by David Davis over 4 years ago

  • Related to Bug #6815: I can delete a environment even if it has associations added

#10 Updated by Ivan Necas over 4 years ago

  • Assignee changed from David Davis to Adam Ruzicka

Ok, assigning this to aruzicka, just for auditing purposes, leaving the deletion of associations untouched for now.

#11 Updated by Eric Helms over 4 years ago

  • Bugzilla link set to 1125358

#12 Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/4571 added
  • Pull request deleted ()

#13 Updated by David Davis over 4 years ago

  • Assignee changed from Adam Ruzicka to Partha Aji
  • Pull request https://github.com/Katello/katello/pull/4563 added
  • Pull request deleted (https://github.com/Katello/katello/pull/4571)

#14 Updated by Partha Aji over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#15 Updated by Eric Helms over 4 years ago

  • Legacy Backlogs Release (now unused) set to 13

Also available in: Atom PDF