Project

General

Profile

Bug #623

Multiple build commit was incomplete

Added by Paul Kelly over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
TFTP
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

The commit was missing the app/views/hosts/multiple_build.html.erb file

plus

There was also a missing call to the forward_request_url method


Related issues

Related to Foreman - Feature #350: Provide the ability to set the build option when editing multiple hostsClosed2010-07-12

Associated revisions

Revision 80e0157c (diff)
Added by Paul Kelly over 8 years ago

Fixes #623 - incomplete multiple builds commit

Signed-off-by: Paul Kelly <>

History

#1 Updated by Paul Kelly over 8 years ago

  • Status changed from New to Ready For Testing
  • Branch set to bug/623-incomplete-multiple-builds

Added the missing multiple_build.html.erb file
Fixed the forward_request_url issue

  • Could you review the queue_tftp_update method and confirm that the line reading "end unless" is correct. **

#2 Updated by Paul Kelly over 8 years ago

Added tests per request

What did you think about the:-

Could you review the queue_tftp_update method and confirm that the line reading "end unless" is correct.

#3 Updated by Ohad Levy over 8 years ago

Paul Kelly wrote:

Added tests per request

What did you think about the:-

Could you review the queue_tftp_update method and confirm that the line reading "end unless" is correct.

hmm thats looks like a mistake - nice catch

#4 Updated by Ohad Levy over 8 years ago

  • Target version set to 0.2

#5 Updated by Ohad Levy over 8 years ago

can you please rebase and post it again the to list?

#6 Updated by Paul Kelly over 8 years ago

rebased, tested and mailed

#7 Updated by Paul Kelly over 8 years ago

  • % Done changed from 0 to 100

#8 Updated by Ohad Levy over 8 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF