Refactor #6287: Convert remaining v2 API controllers to use Api::V2::ApiController - Katello - Foreman

Refactor #6287

Convert remaining v2 API controllers to use Api::V2::ApiController

Added by Walden Raines over 6 years ago. Updated about 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Eric Helms

Category:

API

Target version:

Katello 2.1

Branch:

Difficulty:

medium

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/Katello/katello/pull/4630

Fixed in Releases:

Found in Releases:

Description

These controllers still need to be converted to v2 proper.

[walden@wraines-sandbox katello (master)]$ grep -rl "Api::V1" app/controllers/katello/api/v2 | sort
app/controllers/katello/api/v2/about_controller.rb
app/controllers/katello/api/v2/custom_info_controller.rb
app/controllers/katello/api/v2/distributors_controller.rb
app/controllers/katello/api/v2/host_collection_errata_controller.rb
app/controllers/katello/api/v2/host_collection_packages_controller.rb
app/controllers/katello/api/v2/organization_default_info_controller.rb
app/controllers/katello/api/v2/permissions_controller.rb
app/controllers/katello/api/v2/role_ldap_groups_controller.rb
app/controllers/katello/api/v2/roles_controller.rb
app/controllers/katello/api/v2/root_controller.rb
app/controllers/katello/api/v2/uebercerts_controller.rb

Currently they are all still using v1. We can split these out into individual issues if needed. As part of this we should also remove the remaining v1 code.

Associated revisions

Revision 5006f51b (diff)
Added by Eric Helms about 6 years ago

Fixes #6287: Remove V1 API entirely.

This commit removes the existence of the V1 API by moving some controllers
to pure V2 API controllers and removing other, unused API controllers
and their corresponding tests.

Revision 3b032804
Added by Eric Helms about 6 years ago

Merge pull request #4630 from ehelms/fixes-6287

Fixes #6287: Remove V1 API entirely.

History

#1 Updated by Walden Raines over 6 years ago

Subject changed from Convert remaining v2 controllers to to Convert remaining v2 API controllers to use Api::V2::ApiController

#2 Updated by Walden Raines over 6 years ago

In addition to those above the following v1 API controllers have no v2 counterpart:

app/controllers/katello/api/v1/candlepin_proxies_controller.rb
app/controllers/katello/api/v1/crls_controller.rb
app/controllers/katello/api/v1/errors_controller.rb
app/controllers/katello/api/v1/filters_controller.rb

These should also either be converted or removed.