Project

General

Profile

Refactor #6306

Possible namespace collisions between libraries and proxy modules

Added by Dominic Cleal over 6 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Plugins
Target version:
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

The modular smart proxy has modules named after the component being managed, but in the case of both Chef and Puppet, the proxy module filesystem namespace matches that of the Puppet and Chef gems. This is dangerous as it could create conflicts.

$ head modules/puppet/puppet.rb
require 'puppet/puppet_plugin'
module Proxy::Puppet; end

This is required as "puppet/puppet", and similarly we have things like "puppet/environment". The Puppet code/gem itself is in the same namespace, so we've been very lucky if none of the files we have in modules/*/*.rb match another in one of those projects.

They should probably move into a proxy/ subdirectory to match the namespace of the modules and classes they declare.


Related issues

Related to Smart Proxy - Refactor #4866: As a developer I'd like to break up smart-proxy into multiple componentsClosed2014-03-26

Associated revisions

Revision 69f6b3e5 (diff)
Added by Dmitri Dolguikh over 6 years ago

fixes #6306: removed possible namespace collisions with puppet and chef

History

#1 Updated by Dominic Cleal over 6 years ago

  • Related to Refactor #4866: As a developer I'd like to break up smart-proxy into multiple components added

#2 Updated by Dmitri Dolguikh over 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Dmitri Dolguikh

#3 Updated by Dmitri Dolguikh over 6 years ago

  • Status changed from Assigned to Ready For Testing

#4 Updated by Dominic Cleal over 6 years ago

  • Target version set to 1.8.1

#5 Updated by Anonymous over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF