Project

General

Profile

Bug #6332

Unnecessary taxonomy related SQL queries in authorizer when feature's disabled

Added by Dominic Cleal over 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Users, Roles and Permissions
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

When organisations and locations are disabled, the authorizer (app/services/authorizer.rb) continues to look up taxonomy information from the database, which is an unnecessary cost. It could also lead to issues where taxonomies aren't set up correctly but still influence behaviour, despite being "disabled".

Associated revisions

Revision ea71c8a7 (diff)
Added by Dominic Cleal almost 8 years ago

fixes #6332 - skip taxonomy queries when features are disabled

History

#1 Updated by Dominic Cleal over 8 years ago

Looks like the Filter model also has a cached taxonomy search which should perhaps be omitted/ignored in non-taxonomy configurations.

#2 Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2414 added

#3 Updated by Dominic Cleal almost 8 years ago

  • Assignee set to Dominic Cleal

#4 Updated by Dominic Cleal almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal almost 8 years ago

  • Legacy Backlogs Release (now unused) set to 35

Also available in: Atom PDF