Project

General

Profile

Actions

Bug #6332

closed

Unnecessary taxonomy related SQL queries in authorizer when feature's disabled

Added by Dominic Cleal about 10 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Users, Roles and Permissions
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

When organisations and locations are disabled, the authorizer (app/services/authorizer.rb) continues to look up taxonomy information from the database, which is an unnecessary cost. It could also lead to issues where taxonomies aren't set up correctly but still influence behaviour, despite being "disabled".

Actions #1

Updated by Dominic Cleal about 10 years ago

Looks like the Filter model also has a cached taxonomy search which should perhaps be omitted/ignored in non-taxonomy configurations.

Actions #2

Updated by The Foreman Bot about 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2414 added
Actions #3

Updated by Dominic Cleal about 9 years ago

  • Assignee set to Dominic Cleal
Actions #4

Updated by Dominic Cleal about 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Dominic Cleal about 9 years ago

  • Translation missing: en.field_release set to 35
Actions

Also available in: Atom PDF