Project

General

Profile

Actions

Bug #6421

closed

Turn on rubocop for tests and specs

Added by Partha Aji about 10 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Tests
Target version:
Difficulty:
medium
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

https://github.com/Katello/katello/blob/master/.rubocop.yml#L72-L81 excludes tests and specs from rubocops reach. Unfortunately this means some of use periodically get pull request responses on our testslike
"There are some formatting issues here like indentation and spaces around =>."
We really need to be consistent formatting between tests and functional code.
Need to go thru the rubo cop formatiing issues w.r.t tests.

Actions #1

Updated by Eric Helms about 10 years ago

  • Category set to Tests
  • Difficulty set to medium
  • Triaged changed from No to Yes
Actions #2

Updated by The Foreman Bot almost 10 years ago

  • Status changed from New to Ready For Testing
  • Target version set to 58
  • Pull request https://github.com/Katello/katello/pull/4719 added
Actions #3

Updated by Eric Helms almost 10 years ago

  • Status changed from Ready For Testing to Closed
Actions #4

Updated by Eric Helms over 9 years ago

  • Translation missing: en.field_release set to 14
Actions

Also available in: Atom PDF