Project

General

Profile

Feature #6444

Add ancestry NICs and allow interfaces with same MAC

Added by Marek Hulán about 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Network
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Virtual interfaces can have same MAC addresses so we should validate uniqueness only for physical interfaces. I'll add ancestry to NICs table, parents will be physical interfaces.


Related issues

Related to Foreman - Bug #6787: Turn off the validation on ip addressesNew2014-07-26
Related to Foreman - Tracker #2409: NetworkingNew

Related to Foreman - Bug #7344: unable to import interface facts for certiain network configurationClosed2014-09-03
Blocked by Foreman - Refactor #6560: Extract puppet specific fact parsing logic to isolated classClosed2014-07-10

Associated revisions

Revision d455f32c (diff)
Added by Marek Hulán almost 5 years ago

Fixes #6444 - add support for virtual NICs

Extend additional interface details refs #2240

NIC facts parsing change and we create interfaces in Foreman according
to facts we recieve.

Subclasses does not define their own attributes and serialize them to
attrs hash. All BMC attributes are extracted to separate columns so it's
possible to search NICs by those attributes. Attrs can still be used for
custom attributes (e.g. coming from facts).

NIC form was ajaxified which means that we redraw the form for
particular interface class. We can easily define custom forms for
various interfaces types.

Added support for virtual and physical interfaces. Initial support for bridges
(to keep tests green). New attributes can be set via UI as well.

IPMI facts parsing and BMC NIC creation based on custom facts that are
present in discovery image.

NIC orchestration is now optional and can be set for every interface.
All created interfaces based on facts (BMC or Managed) are not
managed.

Store and update primary interface identifier in host.

Allow subnet selection without domain for NIC so we can use DHCP only.

Suggest IP addresses even without proxy by Foreman itself. Foreman finds
first free IP on a particular Subnet based on records in database.

History

#1 Updated by Lukas Zapletal about 5 years ago

Since Foreman now uses tokens by default, I wonder if we can turn the uniquess off completely.

#2 Updated by Marek Hulán about 5 years ago

  • Status changed from Assigned to Ready For Testing

#3 Updated by Marek Hulán about 5 years ago

I don't think it's a good idea to turn off validation. At least it will let you know that you may have some conflicting device. On the other hand, our validation may be to strict for NICs belonging to different subnets. If you think it's and issue, could you please open another issue?

#4 Updated by Dominic Cleal about 5 years ago

  • Target version set to 1.8.1

#5 Updated by Dmitri Dolguikh about 5 years ago

  • Target version changed from 1.8.1 to 1.8.0

#6 Updated by Marek Hulán about 5 years ago

  • Blocked by Refactor #6560: Extract puppet specific fact parsing logic to isolated class added

#7 Updated by Marek Hulán about 5 years ago

  • Status changed from Ready For Testing to Assigned

We should add also some UI to define various network types. Also we should parse facts and create/update interfaces. Hence changing back to assigned.

#8 Updated by The Foreman Bot about 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1565 added
  • Pull request deleted ()

#9 Updated by Ivan Necas almost 5 years ago

  • Related to Bug #6787: Turn off the validation on ip addresses added

#10 Updated by Dmitri Dolguikh almost 5 years ago

  • Target version changed from 1.8.0 to 1.7.5

#11 Updated by Ohad Levy almost 5 years ago

#12 Updated by Dmitri Dolguikh almost 5 years ago

  • Target version changed from 1.7.5 to 1.7.4

#13 Updated by Dominic Cleal almost 5 years ago

  • Legacy Backlogs Release (now unused) set to 21

#14 Updated by Marek Hulán almost 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#15 Updated by Dominic Cleal almost 5 years ago

  • Related to Bug #7344: unable to import interface facts for certiain network configuration added

#16 Updated by Bryan Kearney over 4 years ago

  • Bugzilla link set to 1166163

Also available in: Atom PDF