Project

General

Profile

Bug #6588

Tests for default settings are taking local config files into account

Added by Dominic Cleal over 6 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

I have some settings which appear to interfere with unit tests for default settings:

[ 77/218] DnsConfigTest#test_omitted_settings_have_default_values = 0.00 s                                      
  1) Failure:
test_omitted_settings_have_default_values(DnsConfigTest) [/home/dcleal/code/foreman/smart-proxy/test/dns/dns_config_test.rb:7]:
<"nsupdate"> expected but was
<"virsh">.

[158/218] PuppetCAConfigTest#test_omitted_settings_have_default_values = 0.00 s                                                      
  2) Failure:
test_omitted_settings_have_default_values(PuppetCAConfigTest) [/home/dcleal/code/foreman/smart-proxy/test/puppetca/puppetca_config_test.rb:6]:
<"/var/lib/puppet/ssl"> expected but was
<"/home/dcleal/.puppet/ssl">.

As you can see, I have these overridden locally:

[dcleal@cobalt smart-proxy]$ grep ssldir config/settings.d/puppetca.yml
:ssldir: /home/dcleal/.puppet/ssl
[dcleal@cobalt smart-proxy]$ grep virsh config/settings.yml
:virsh_network: default

Associated revisions

Revision a52a4f69 (diff)
Added by Dominic Cleal over 6 years ago

fixes #6588 - don't load user settings when testing default settings

History

#1 Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing

#2 Updated by The Foreman Bot over 6 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/186 added
  • Pull request deleted ()

#3 Updated by The Foreman Bot over 6 years ago

  • Target version set to 1.8.0

#4 Updated by Dominic Cleal over 6 years ago

  • Assignee set to Dominic Cleal

#5 Updated by Dominic Cleal over 6 years ago

  • Status changed from Ready For Testing to Assigned
  • Target version deleted (1.8.0)
  • Pull request added
  • Pull request deleted (https://github.com/theforeman/smart-proxy/pull/186)

#6 Updated by The Foreman Bot over 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Target version set to 1.8.0
  • Pull request https://github.com/theforeman/smart-proxy/pull/186 added
  • Pull request deleted ()

#7 Updated by Dominic Cleal over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF