Project

General

Profile

Bug #6655

Clear _ForemanSelectedhosts cookie when an action is performed

Added by Dylan Charleston about 8 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

We recently had an incident where a large number of our production boxes were accidently deleted in part due to user error and another in what I think should be labeled as a bug.

Current behavior:
User does a search for specific hosts, selects a number of hosts to perform an action on. These host ids are added to the _ForemanSelectedhosts cookie. User executes action. User searches for another host and selects it for a action. _ForemanSelectedhosts still contains hosts from the previous selection even though they don't show up in the most recent search. You can verify this by highlighting over the top select checkbox or on the verification page when you go to perform the action.

Suggested behavior:
Though the hosts show up in the verification popup when you perform the action, you don't expect hosts that weren't recently selected to still be included in the action. I think it makes sense to clear the _ForemanSelectedhosts cookie once an action like "Build hosts" or "Change Group" has been performed.


Related issues

Related to Foreman - Bug #3310: Hosts stay selected after host table refreshNew2013-10-16
Related to Foreman - Bug #9880: Selected hosts remain after closing and revisiting host listNew2015-03-24
Related to Foreman - Bug #10408: Host checkboxes get cleared after action takenClosed2015-05-07

Associated revisions

Revision 8f38e945 (diff)
Added by Shlomi Zadok over 7 years ago

fixes #6655 - remove _ForemanSelectedhosts cookie on action submit

History

#1 Updated by Dominic Cleal about 8 years ago

  • Category set to Web Interface

#2 Updated by Dominic Cleal almost 8 years ago

  • Related to Bug #3310: Hosts stay selected after host table refresh added

#3 Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2167 added
  • Pull request deleted ()

#4 Updated by Dominic Cleal over 7 years ago

  • Assignee set to Shlomi Zadok
  • Legacy Backlogs Release (now unused) set to 28

#5 Updated by Shlomi Zadok over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Dominic Cleal over 7 years ago

  • Related to Bug #9880: Selected hosts remain after closing and revisiting host list added

#7 Updated by Dominic Cleal over 7 years ago

  • Related to Bug #10408: Host checkboxes get cleared after action taken added

#8 Updated by Lukas Zapletal almost 7 years ago

  • Bugzilla link set to 1258460

Also available in: Atom PDF