Project

General

Profile

Bug #6695

Adding two OS parameters with same name doesn't raise any error when values are different

Added by Ori Rabin about 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Database
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1120657
Description of problem:
I was trying to perform some boundary tests on OS parameters. I defined OS parameter say release_ver with value 2.6.14
I defined same parameter again with value 2.6.16

Both parameters were created successfully. Please see the screenshot.

However when I defined release_ver two times with same values, then on submit, the page moves to 'operating System' tab instead of 'Parameters' tab.

Version-Release number of selected component (if applicable):
Sat6 GA snap0

How reproducible:
always

Steps to Reproduce:
1. create OS and following parameters
a) release_ver with value 2.6.14
b) release_ver with value 2.6.16

2. OS should be created with above parameters.
3. Now update the first parameter b) release_ver with value 2.6.14 from 2.16.16
4. UI switched to other tab, Now UI raises error 'Name already taken" but switched to other tab

Actual results:
There are two issues:
1. when parameters name are same but values are different then UI doesn't raise any error
2. when parameter name as well as value are same then UI raises error but quickly switch to other tab and error remains under 'Parameters' tab

Expected results:
1. when parameters name are same but values are different, still UI raise error like Validation Error: Name already taken
2. when parameter name as well as value are same then UI shouldn't switch the tab, it should stay on 'Parameters' tab

Additional info:


Related issues

Related to Foreman - Bug #6693: UI shouldn't switch to other tab while creating OS parameters with same name or with blank name/valuesClosed2014-07-20
Related to Foreman - Bug #8366: Upgrade from 1.6.2 to 1.7rc1 fails during AddUniqueIndexToParameter db migration with duplicate key errorClosed2014-11-12
Related to Foreman - Bug #11339: parameter unique index migration should account for duplicate dataClosed2015-08-12
Has duplicate Foreman - Bug #7776: It is possible to register multiple parameters with the same name using the REST APIResolved2014-10-02

Associated revisions

Revision 998e1438 (diff)
Added by Ori Rabin almost 5 years ago

Fixes #6695: Adding two OS parameters with same name should raise an error

History

#1 Updated by Dominic Cleal almost 5 years ago

  • Category set to Database

The stuff about showing the parameters tab (i.e. any form tab where there are errors) is #6693.

#2 Updated by Dominic Cleal almost 5 years ago

  • Related to Bug #6693: UI shouldn't switch to other tab while creating OS parameters with same name or with blank name/values added

#3 Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Target version set to 1.8.0
  • Pull request https://github.com/theforeman/foreman/pull/1607 added
  • Pull request deleted ()

#4 Updated by Dmitri Dolguikh almost 5 years ago

  • Target version changed from 1.8.0 to 1.7.5

#5 Updated by Dmitri Dolguikh almost 5 years ago

  • Target version changed from 1.7.5 to 1.7.4

#6 Updated by Dmitri Dolguikh almost 5 years ago

  • Target version changed from 1.7.4 to 1.7.3

#7 Updated by Daniel Lobato Garcia almost 5 years ago

  • Legacy Backlogs Release (now unused) set to 22

Reasons for 1.6.1 - No i18n strings, bug, not feature, not an enormous change.

#8 Updated by Dominic Cleal almost 5 years ago

Daniel Lobato Garcia wrote:

Reasons for 1.6.1 - No i18n strings, bug, not feature, not an enormous change.

Please move to 1.7.0, it includes a schema change and a new string.

#9 Updated by Dominic Cleal almost 5 years ago

  • Legacy Backlogs Release (now unused) changed from 22 to 21

#10 Updated by Ori Rabin almost 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#11 Updated by Dominic Cleal almost 5 years ago

  • Has duplicate Bug #7776: It is possible to register multiple parameters with the same name using the REST API added

#12 Updated by Dominic Cleal over 4 years ago

  • Related to Bug #8366: Upgrade from 1.6.2 to 1.7rc1 fails during AddUniqueIndexToParameter db migration with duplicate key error added

#13 Updated by Dominic Cleal almost 4 years ago

  • Related to Bug #11339: parameter unique index migration should account for duplicate data added

Also available in: Atom PDF