Project

General

Profile

Actions
Copy link

Bug #6700

closed

Proxy::Puppet::Runner incorrectly checked $? for success

Added by Dominic Cleal over 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Aaron Stone
Category:
Tests
Target version:
1.6.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/187
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

"The popen test was looking at $?, but it wasn't set by the method under test. Testing Ruby's popen method isn't terribly helpful, it's a built-in.

This replaces the popen test with a test for the shell_command wrapper and adds tests for the other methods in Proxy::Puppet::Runner."

Actions
Copy link
 #1

Updated by Aaron Stone over 10 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF