Bug #6761
closed
Slow hammer startup times (1.3+ seconds)
Description
Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1122810
Description of problem:
When running "hammer --help", it's taking in excess of 1.3 seconds. This makes it inefficient for use in a shell script, particularly when needing to retrieve IDs or run checks in other commands.
Version-Release number of selected component (if applicable):
rubygem-hammer_cli-0.1.1-5.el6sat
rubygem-hammer_cli_foreman-0.1.1-9.el6sat
How reproducible:
Always
Steps to Reproduce:
1. time hammer --help
2.
3.
Actual results:
= 1.3 seconds
Expected results:
< 0.5 seconds?
Updated by Dominic Cleal over 10 years ago
- Category set to Hammer core
- Priority changed from High to Normal
Updated by Tomáš Strachota over 10 years ago
- Status changed from New to Assigned
- Assignee set to Tomáš Strachota
Updated by The Foreman Bot over 10 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/hammer-cli/pull/126 added
- Pull request deleted (
)
Updated by Tomáš Strachota over 10 years ago
Most time consuming turned out to be command and option definition that takes place at class level. Lazy loading of subcommands strips most of the unnecessary requires.
My measurements showed times slightly <0.5s for hammer -h (or around 0.8 when running in bundler).
https://github.com/theforeman/hammer-cli/pull/126
https://github.com/theforeman/hammer-cli-foreman/pull/139
https://github.com/Katello/hammer-cli-katello/pull/210
Updated by Anonymous over 10 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset hammer-cli-foreman|4fbd36b414aaf030e9dfda79fe4ccdd304d9faa7.