Bug #7038
closedPGError when hostgroup name exceeds 245 characters
Description
Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1129202
Description of problem:
I was trying to validate the hostgroup form and found that if we enter more than 245 chars in 'Name' field of hostgroup, It raises PGError:
--
Processing by HostgroupsController#update as HTML
Parameters: {"utf8"=>"✓", "authenticity_token"=>"8YKMIr6xgzHyJpwH0LC3VbHzoQSwOk+VOG2XoH0FhiE=", "hostgroup"=>{"name"=>"SSTQOPqJiwFllLmBmDRZoWsarPNwQhcEypKFfTozMHnmPtTqkgebNCMSMxBdywiWmEbraUdMnjnSIvdKFeioxAgvPTutMitBTTRExegkJRTzxlAHDIasfjwEAabNhzvevKiTDbYXbaqVFArexnApWfavHFpPSoDothzHwKVZOYrqGtSicQxHHrBoLcuNwrANGduNLMCurtGjlrkweKZNVqDaxmOPfvHBQjwapFpfbhLxGPksMwxGn1", "environment_id"=>"", "content_source_id"=>"", "puppet_ca_proxy_id"=>"", "puppet_proxy_id"=>"", "domain_id"=>"", "realm_id"=>"", "architecture_id"=>"", "root_pass"=>"[FILTERED]", "location_ids"=>[""], "organization_ids"=>[""]}, "kt_environment_id"=>"", "kt_activation_keys"=>"", "commit"=>"Submit", "id"=>"16-sstqopqjiwflllmbmdrzowsarpnwqhceypkfftozmhnmpttqkgebncmsmxbdywiwmebraudmnjnsivdkfeioxagvptutmitbttrexegkjrtzxlahdiasfjweaabnhzvevkitdbyxbaqvfarexnapwfavhfppsodothzhwkvzoyrqgtsicqxhhrbolcunwrangdunlmcurtgjlrkwekznvqdaxmopfvhbqjwapfpfbhlxgpksmwxgn"}
Operation FAILED: PGError: ERROR: value too long for type character varying(255)
: UPDATE "lookup_values" SET "match" = 'hostgroup=SSTQOPqJiwFllLmBmDRZoWsarPNwQhcEypKFfTozMHnmPtTqkgebNCMSMxBdywiWmEbraUdMnjnSIvdKFeioxAgvPTutMitBTTRExegkJRTzxlAHDIasfjwEAabNhzvevKiTDbYXbaqVFArexnApWfavHFpPSoDothzHwKVZOYrqGtSicQxHHrBoLcuNwrANGduNLMCurtGjlrkweKZNVqDaxmOPfvHBQjwapFpfbhLxGPksMwxGn1' WHERE "lookup_values"."match" = 'hostgroup=SSTQOPqJiwFllLmBmDRZoWsarPNwQhcEypKFfTozMHnmPtTqkgebNCMSMxBdywiWmEbraUdMnjnSIvdKFeioxAgvPTutMitBTTRExegkJRTzxlAHDIasfjwEAabNhzvevKiTDbYXbaqVFArexnApWfavHFpPSoDothzHwKVZOYrqGtSicQxHHrBoLcuNwrANGduNLMCurtGjlrkweKZNVqDaxmOPfvHBQjwapFpfbhLxGPksMwxGn'
Rendered common/500.html.erb within layouts/application (5.7ms)
Rendered layouts/base.html.erb (1.4ms)
Completed 500 Internal Server Error in 67ms (Views: 9.7ms | ActiveRecord: 8.1ms)
---
Version-Release number of selected component (if applicable):
sat6 GA snap4
How reproducible:
always
Steps to Reproduce:
1. create hostgroup with more than 245 char in name
2.
3.
Actual results:
Operation FAILED: PGError: ERROR: value too long for type character varying(255)
Expected results:
User should be allowed to enter 255 char in name field and if it exceeds 255 char then UI should throw a clean validation error instead of PGError
Additional info:
Updated by Dominic Cleal about 10 years ago
- Category set to Database
- Priority changed from Low to Normal
Note that this isn't actually the host group name field causing the problem, it's the smart matchers (lookup_values).
Updated by Ori Rabin about 10 years ago
- Related to Bug #6694: PGError: while creating OS with long (greater than 5 chars) minor/major version values added
Updated by Ori Rabin about 10 years ago
- Status changed from New to Resolved
- Assignee set to Ori Rabin
This was resolved when #6694 was fixed
Updated by Dominic Cleal about 10 years ago
Are you sure? I was able to reproduce the problem here on a nightly RPM installation. Note that it's the lookup_values causing the problem, not the name attribute of the hostgroup.
Updated by Ori Rabin about 10 years ago
- Status changed from Resolved to Assigned
Updated by The Foreman Bot about 10 years ago
- Status changed from Assigned to Ready For Testing
- Target version set to 1.7.5
- Pull request https://github.com/theforeman/foreman/pull/1686 added
- Pull request deleted (
)
Updated by Ori Rabin about 10 years ago
- Pull request https://github.com/theforeman/foreman/pull/1701 added
- Pull request deleted (
https://github.com/theforeman/foreman/pull/1686)
Updated by Anonymous about 10 years ago
- Target version changed from 1.7.5 to 1.7.4
Updated by Anonymous about 10 years ago
- Target version changed from 1.7.4 to 1.7.3
Updated by Ori Rabin almost 10 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 5fbe760e04c27400c054c6260f6ffcfec72c2c8c.
Updated by Dominic Cleal almost 10 years ago
- Translation missing: en.field_release set to 21
Updated by Dominic Cleal almost 10 years ago
- Related to Bug #7437: PGError when host group title is exactly 256 characters added
Updated by Ori Rabin almost 10 years ago
The error is a result of the lookup_value matchers that are created using the host title.
In the lookup_value table 'match' is a string column and I couldn't change it to text because there is an index on it.
Mysql doesn't really allow indexes on text columns, there is a workaround that didn't work for match.
To fix the error, the host name is now restricted so that it's title will not cause the matcher to be longer then 255 characters.
If there is a fix for the `match` attribute it will be a better fix to turn it into a text column and remove the restriction
Updated by Ori Rabin almost 10 years ago
- Related to Refactor #7439: Host group name limited because lookup_value 'match' is a string added
Updated by Ori Rabin almost 10 years ago
- Related to Bug #7624: location and organization char names are capped to 246 instead of 255 added