Project

General

Profile

Bug #708

Domain checking code doubling up domain in hostnames

Added by Frank Sweetser over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Category:
Host creation
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

In 0.1-6, foreman began checking to ensure that hostnames which have the domain column set to a non-null value end in the matching domain value. However, the code that does the check is doing case-sensitive matching, which can cause hosts to have doubled up hostnames. For example, "host.domain.com" might become "host.domain.com.DOMAIN.COM", which of course means that future check-ins, reports, etc don't get associated with that host. Instead, an empty new record for "host.domain.com" appears to get created (from the reports, perhaps?) which needs to be deleted after fixing the original record.

Trivial patch that fixes the issue attached.

Associated revisions

Revision 99f00455 (diff)
Added by Frank Sweetser over 11 years ago

fixes #708 - Perform case insensitive match when checking if hostname includes domain

Revision 7736608a (diff)
Added by Ben Roberts 5 months ago

Support multiple envs_dir directories

This module adds support for the puppet environmentpath setting to be configured
using multiple directories. An example use-case is where r10k is in use to
deploy some but not all environments, to avoid unmanaged environments being
purged by r10k. Directories (whether one, or multiple) are passed as an
Array of Stdlib::Absolutepath values.

This is a breaking change, as a single string will no longer be accepted.

- Each listed environmentpath directory will be created and managed by puppet
- The default post-receive hook script uses the first listed directory in
`envs_dir` to create initial environments to maintain backward compatibility.

Tests are included to ensure that all listed directories are created and
managed.

Fixes #708

History

#1 Updated by Frank Sweetser over 11 years ago

  • Status changed from New to Ready For Testing
  • % Done changed from 0 to 100

#2 Updated by Ohad Levy over 11 years ago

  • Category set to Host creation
  • Status changed from Ready For Testing to Closed
  • Assignee set to Frank Sweetser
  • Target version set to 0.2

Also available in: Atom PDF