Refactor #7191

Move API response body logging to enable plugins to skip it

Added by Dominic Cleal almost 4 years ago. Updated 8 days ago.

Status:Closed
Priority:Normal
Assignee:Dominic Cleal
Category:API
Target version:1.6.0
Difficulty: Team Backlog:
Triaged: Fixed in Releases:
Bugzilla link: Found in Releases:
Pull request:https://github.com/theforeman/foreman/pull/1705

Description

The API base controller currently has an anonymous after_filter that logs the response body at debug level. For foreman_bootdisk, which is returning large amounts of binary data, this needs disabling as it all gets logged, slowing down the app and generating huge log files.

It should be in a named filter so it's possible to skip the filter in a subclass of the API base controller.

Associated revisions

Revision 843f0b49
Added by Dominic Cleal almost 4 years ago

refs #7191 - disable logging of disk download responses

Revision 5c631b88
Added by Dominic Cleal almost 4 years ago

fixes #7191 - move API response logger to named filter so it can be skipped

Revision 31adc63e
Added by Dominic Cleal almost 4 years ago

fixes #7191 - move API response logger to named filter so it can be skipped

(cherry picked from commit 5c631b880310c18cd4ab2b711293bc1c7d3310bd)

History

#1 Updated by The Foreman Bot almost 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1705 added

#2 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 10

#3 Updated by Dominic Cleal almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF