Edit organization displays associated resources for use w/o permissions
A user with the below permissions can incorrectly see the following on an organization edit page. Note that because the tabs are displayed the list of resources available in each are also displayed. This implies that the choices are not being reduce to show only those available to a specific user.
What I mean is that if user A has a filter that allowed them to only see "Alterator default" Template, then the list should contain only that template. It is my guess that this is not the case. Maybe worth a separate bug but suspect it is all related.
If no permission for resource at all, do not render tab at all.
For limited permissions, display only those resources that are accessible.
Name,Count,Resource,Search,Permissions,Organizations,Locations SAM Administrator,1,Katello::ActivationKey,"","view_activation_keys,create_activation_keys,edit_activation_keys,destroy_activation_keys",,"" SAM Administrator,1,Katello::System,"","view_content_hosts,create_content_hosts,edit_content_hosts,destroy_content_hosts",,"" SAM Administrator,1,Katello::ContentView,"",view_content_views,,"" SAM Administrator,1,Katello::HostCollection,"","view_host_collections,create_host_collections,edit_host_collections,destroy_host_collections",,"" SAM Administrator,1,Katello::KTEnvironment,"",view_lifecycle_environments,,"" SAM Administrator,1,Katello::Product,"","view_products,sync_products",,"" SAM Administrator,1,Organization,"","view_organizations,create_organizations,edit_organizations,destroy_organizations,assign_organizations,view_subscriptions,attach_subscriptions,unattach_subscriptions,import_manifest,delete_manifest",,"" SAM Administrator,1,Role,"","view_roles,create_roles,edit_roles,destroy_roles",,"" SAM Administrator,1,Filter,"","view_filters,create_filters,edit_filters,destroy_filters",,"" SAM Administrator,1,User,"","view_users,create_users,edit_users,destroy_users",,"" SAM Administrator,1,Usergroup,"","view_usergroups,create_usergroups,edit_usergroups,destroy_usergroups",,""
Updated by Thomas McKay over 9 years ago
<thomasmckay> ehelms: working #7221 what should the perms be to view and edit associations with org/loc? https://github.com/theforeman/foreman/blob/develop/app/views/taxonomies/_form.html.erb#L16 <nudnik> ehelms: #7221 is http://theforeman.org/issues/7221 "Bug #7221: Edit organization displays associated resources for use w/o permissions - Foreman" <thomasmckay> i think that page should just check view permission on the resource to show the tab <thomasmckay> and then edit perm on at least org to adjust assocations. should edit perm on the smart-proxy, in this case, also be required? <ehelms> thomasmckay: depends how you look at it, are you changing the org or the object? does adding an organization to a smart proxy change the proxy, the organization or both? <ehelms> thomasmckay: I lean towards just the object <thomasmckay> i'd say both since you are basically letting it be used in that org <thomasmckay> ehelms: your vote is edit perm on the resource, but not require edit on the org? <thomasmckay> should you be able to create a subnet in an org you don't have edit perm on? <thomasmckay> i guess yes... yeah, i think you're right <thomasmckay> so view on org but edit on resource <ehelms> thomasmckay: that's how katello at least works when you think about it