Feature #7289
open
ACL who can add a host to hostgroup.
Description
With foreman 1.4 if a user had edit rights to a host due to a filter applied to a subset of hostgroups
they could
- Move a host to any hostgroup via API
- however when editing via web interface they were at least only
presented with hosgroups to which they were enabled in filter.
With foreman 1.5 the first point is still true that via API a host can be put in any hostgroup
but also the drop down box contains all hostgroups so it's a bit more obvious.
Having set up a role like the following with 1.5.
| Resource | Permissions | Search |
| hostgroup | view_hostgroups, create_hostgroups, edit_hostgroups, destroy_hostgroups | title = cvmfs or title ~ cvmfs/% |
| Host/managed | view_hosts, create_hosts, destroy_hosts, console_hosts, build_hosts, edit_hosts, ipmi_boot, power_hosts, puppetrun_hosts | hostgroup_title = cvmfs or hostgroup_title ~ cvmfs/% |
You also get the slightly bizare consequence that a user can edit a host in such a way that they then no longer
have access to it.
The RFE is to request to somehow control which hostgroups a user is permitted to put hosts in. Returning to old
1.4 behaviour where the drop down box was limited to hostgroups that can be viewed would also be good.
Updated by Dominic Cleal about 10 years ago
- Related to Feature #4477: Improve permissions on resources in host creation/editing form added
Updated by Dominic Cleal about 10 years ago
- Tracker changed from Bug to Feature
- Subject changed from RFE - ACL who can add a host to hostgroup. to ACL who can add a host to hostgroup.
#4477 and related bugs have some discussion about this, it's something we're beginning to look at across the application (associated resources).
Updated by Dominic Cleal about 9 years ago
- Has duplicate Bug #12349: Filtering host groups does not work in the host creation screen added
Updated by Dominic Cleal over 8 years ago
- Has duplicate Bug #14248: Unable to control where users can build hosts added
Updated by
Updated by Tomer Brisker over 8 years ago
- Has duplicate deleted (Bug #14248: Unable to control where users can build hosts)
Updated by Tomer Brisker over 8 years ago
- Related to Bug #14248: Unable to control where users can build hosts added
Updated by Marek Hulán over 8 years ago
- Status changed from New to Duplicate
I believe this has been fixed by #4477 in 1.13.
Updated by Nacho Barrientos about 8 years ago
Hi,
Is the patch fixing this issue [0] preventing users from creating hosts via the API in the hostgroup of their choice no matter what are the roles assigned to the caller?
We haven't backported the patch yet to verify ourselves, but at a glance it does not seem to fix the issue described above by Steve.
[0] https://github.com/theforeman/foreman/commit/a4d69f8c15495ca8e9595f0f1503174e888f30b9
Updated by Dominic Cleal about 8 years ago
- Status changed from Duplicate to New
I agree, #4477 only intended to improve the UI and doesn't enforce any permissions between objects, including hosts within host groups.
Updated by Marek Hulán about 8 years ago
Ok, I thought it returned the described 1.4 behavior. So if I understand you correctly, to fix this issue we need to add permissions checking for hostgroups being assigned to host. Is it desirable to control it via view_hostgroup permission or create_host permission?
EDIT: or even new host group permission called "assign_to_host"?
Updated by Dominic Cleal about 8 years ago
Updated by Marek Hulán about 8 years ago
- Related to Bug #6760: Models should ensure the authorization of associated objects before associating them to the model added
Updated by Nacho Barrientos about 8 years ago
Any chance this gets some love anytime soon? Thanks :)