Bug #7297

Virsh error handlers throw "uninitialized constant Proxy::DNS" error

Added by Dominic Cleal almost 4 years ago. Updated 7 days ago.

Status:Closed
Priority:Normal
Assignee:Dominic Cleal
Category:DNS
Target version:1.6.1
Difficulty: Team Backlog:
Triaged: Fixed in Releases:
Bugzilla link: Found in Releases:
Pull request:https://github.com/theforeman/smart-proxy/pull/208

Description

When a virsh update fails, the error handlers in lib/proxy/virsh.rb throw an uninitialized constant error themselves:

D, [2014-08-29T11:12:17.142706 #24336] DEBUG -- : /usr/bin/sudo /usr/bin/virsh net-update default add-last dns-host --xml '<host ip="192.168.122.112"><hostname>pdb2.example.com</hostname></host>' --live --config 2>&1
E, [2014-08-29T11:12:17.195826 #24336] ERROR -- : uninitialized constant Proxy::DNS
D, [2014-08-29T11:12:17.195996 #24336] DEBUG -- : /home/dcleal/code/foreman/smart-proxy/lib/proxy/virsh.rb:54:in `rescue in virsh_update_dns'
/home/dcleal/code/foreman/smart-proxy/lib/proxy/virsh.rb:47:in `virsh_update_dns'
/home/dcleal/code/foreman/smart-proxy/modules/dns/providers/virsh.rb:17:in `create'
/home/dcleal/code/foreman/smart-proxy/modules/dns/dns_api.rb:47:in `block in <class:Api>'

Related issues

Related to Smart Proxy - Refactor #7298: Remove Proxy::Virsh dependencies on dns and dhcp modules Closed 08/29/2014

Associated revisions

Revision b32f2f77
Added by Dominic Cleal almost 4 years ago

fixes #7297 - corrected name of DNS namespace in virsh error handlers

Refactored DNS and DHCP specifics back into the respective modules

History

#1 Updated by The Foreman Bot almost 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/208 added

#2 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) changed from 10 to 22

#3 Updated by Dmitri Dolguikh almost 4 years ago

  • Target version changed from 1.7.4 to 1.7.3

#4 Updated by Dominic Cleal almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal over 2 years ago

  • Related to Refactor #7298: Remove Proxy::Virsh dependencies on dns and dhcp modules added

Also available in: Atom PDF