Project

General

Profile

Actions

Bug #7314

closed

Tests shouldn't stub settings

Added by Stephen Benjamin almost 10 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Tests
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

If you stub Settings[], and a plug-in later comes along and chains the method and references a Setting that's not stubbed, it will cause the test to fail.

Setting the setting value in the test works, so there's really no need to stub Settings, is there?

Actions #1

Updated by The Foreman Bot almost 10 years ago

  • Status changed from New to Ready For Testing
  • Target version set to 1.7.4
  • Pull request https://github.com/theforeman/foreman/pull/1722 added
  • Pull request deleted ()
Actions #2

Updated by Anonymous almost 10 years ago

  • Target version changed from 1.7.4 to 1.7.3
Actions #3

Updated by Dominic Cleal almost 10 years ago

  • Assignee set to Stephen Benjamin
  • Translation missing: en.field_release set to 21
Actions #4

Updated by Anonymous almost 10 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF