Project

General

Profile

Bug #7314

Tests shouldn't stub settings

Added by Stephen Benjamin about 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Stephen Benjamin
Category:
Tests
Target version:
1.7.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/1722
Fixed in Releases:
Found in Releases:

Description

If you stub Settings[], and a plug-in later comes along and chains the method and references a Setting that's not stubbed, it will cause the test to fail.

Setting the setting value in the test works, so there's really no need to stub Settings, is there?

Associated revisions

Revision 777a7ddd (diff)
Added by Stephen Benjamin about 5 years ago

fixes #7314 - Set settings explicitly instead of stubbing Settings

History

#1 Updated by The Foreman Bot about 5 years ago

  • Status changed from New to Ready For Testing
  • Target version set to 1.7.4
  • Pull request https://github.com/theforeman/foreman/pull/1722 added
  • Pull request deleted ()

#2 Updated by Dmitri Dolguikh about 5 years ago

  • Target version changed from 1.7.4 to 1.7.3

#3 Updated by Dominic Cleal about 5 years ago

  • Assignee set to Stephen Benjamin
  • Legacy Backlogs Release (now unused) set to 21

#4 Updated by Anonymous about 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF