Project

General

Profile

Bug #7378

foreman api v2, GET to /api/v2/puppetclasses/foo/smart_class_parameters returns ALL smart class parameters for all puppet classes, if foo is not a valid puppet class

Added by Petter Hassberg about 6 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Category:
API
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

When doing an API GET request to /api/v2/puppetclasses/foo it returns a 404 unless there is a puppet class named foo.

If however, the get request is as follows /api/v2/puppetclasses/foo/smart_class_parameters, if foo is not a puppet class, it will list all the smart class parameters for all puppet classes.

this can be I think dangerous.

Associated revisions

Revision bc68c48d (diff)
Added by Martin Bacovsky over 5 years ago

Fixes #7378 - fixed API lookup keys filters

Revision 0d6ea512 (diff)
Added by Martin Bacovsky over 5 years ago

Fixes #7378 - fixed API lookup keys filters

(cherry picked from commit bc68c48da5b718084c3e531e61e48124e8e00d36)

History

#1 Updated by Martin Bacovsky almost 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Martin Bacovsky
  • Target version set to 1.7.2

#2 Updated by The Foreman Bot almost 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1835 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal over 5 years ago

  • Legacy Backlogs Release (now unused) set to 28

#4 Updated by Anonymous over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF