Project

General

Profile

Bug #7496

change has_and_belongs_to_many to has_many :through and add unique validation and auditing to join table

Added by Joseph Magen over 7 years ago. Updated almost 4 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Rails
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/1773
Fixed in Releases:
Found in Releases:

Description

there is currently no validation when the models use has_and_belongs_to_many

This issue is a result of needing to generate validation errors and audit trail for https://github.com/theforeman/foreman/pull/1454

History

#1 Updated by Dominic Cleal over 7 years ago

  • Category set to Rails

#2 Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Target version set to 1.7.3
  • Pull request https://github.com/theforeman/foreman/pull/1773 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal over 7 years ago

  • Target version changed from 1.7.3 to 1.7.2

#4 Updated by Joseph Magen about 6 years ago

  • Status changed from Ready For Testing to New

Moving status back to New. PR https://github.com/theforeman/foreman/pull/1773 is not complete but it's a start.

I don't recall what could cause two identical rows in the join table. I see this task as a "nice to have" and not "must have" as it changes a lot of code with little upside unless there is a real pain there something is causing duplicate rows.

#5 Updated by Tomer Brisker almost 4 years ago

  • Target version deleted (1.7.2)

Also available in: Atom PDF