Project

General

Profile

Bug #7574

update confirm option for the link_to helper to be data attribute for rails 4 upgrade

Added by Joseph Magen over 8 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tom Caspy
Category:
Rails
Target version:
1.9.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2476
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

data: { confirm: 'Are you sure?' }

Related issues

Related to Foreman - Tracker #3157: Rails 4.1 upgrade tasksClosed2013-09-27

Related to Foreman - Refactor #26327: deprecate allowing passing :confirm directly to link_to helperClosed

Associated revisions

Revision 4f211508 (diff)
Added by Daniel Lobato Garcia almost 8 years ago

Fixes #7574 - Rails 4 :data attributes substitute deprecated HTML options

History

#1 Updated by Joseph Magen over 8 years ago

#2 Updated by Ohad Levy over 8 years ago

  • Legacy Backlogs Release (now unused) set to 21

#3 Updated by Ohad Levy over 8 years ago

  • Legacy Backlogs Release (now unused) deleted (21)

#4 Updated by Tom Caspy over 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tom Caspy

#5 Updated by The Foreman Bot almost 8 years ago

  • Pull request https://github.com/theforeman/foreman/pull/2476 added
  • Pull request deleted ()

#6 Updated by Dominic Cleal almost 8 years ago

  • Legacy Backlogs Release (now unused) set to 35

#7 Updated by Daniel Lobato Garcia almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#8 Updated by Tomer Brisker about 4 years ago

  • Related to Refactor #26327: deprecate allowing passing :confirm directly to link_to helper added

Also available in: Atom PDF