Feature #7587
Javascript validation of passwords on Edit User screen
Description
Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1145626
++ This bug was initially created as a clone of Bug #1145307 ++
Description of problem:
We don't do any validation or assisting around the creation of passwords on the Edit User page. They can enter passwords that don't match without knowing until they try to change it. There's no strength indicator either.
Version-Release number of selected component (if applicable):
foreman-installer-1.5.0-0.6.RC2.el6ost.noarch
rhel-osp-installer-0.1.10-2.el6ost.noarch
openstack-foreman-installer-2.0.20-1.el6ost.noarch
Additional info:
Associated revisions
refs #7587 - add jquery_pwstrength_bootstrap asset gem
refs #7587 - precompile pwstrength JS, move gem from runtime deps
Refs #7587 - Refactor password confirmation
- confirmation status is now linked to password field
- extracted additional missing strings
- simplified jquery selectors
- switched to onKeyUp built in event
- hide progress bar by default
- fixed minor css
- handle empty pw/confirmation
- moved javascript/stylesheet into partial instead of new/edit
- moved inline js to onContentLoad event.
refs #7587 - pwstrength stylesheet is part of app.css, not standalone
History
#1
Updated by Dominic Cleal almost 8 years ago
- Category set to Web Interface
#2
Updated by b sh almost 8 years ago
There are two ways to do that: (1) Write our own Ruby validation method that checks the password strength, or (2) use an open source project, such as plugins.jquery.com/pwstrength-bootstrap/.
Personally, I prefer the latter one.
#3
Updated by Ohad Levy almost 8 years ago
b sh wrote:
There are two ways to do that: (1) Write our own Ruby validation method that checks the password strength, or (2) use an open source project, such as plugins.jquery.com/pwstrength-bootstrap/.
Personally, I prefer the latter one.
I tent to agree, but at the moment the url you sent above is not reachable.. :)
#4
Updated by b sh almost 8 years ago
Yeah, you're right. Well, anyway - that's its github repo:
https://github.com/ablanco/jquery.pwstrength.bootstrap
;-)
#5
Updated by Ohad Levy almost 8 years ago
b sh wrote:
Yeah, you're right. Well, anyway - that's its github repo:
https://github.com/ablanco/jquery.pwstrength.bootstrap
;-)
you probably want to consider something like a rails engine with the assets already, very quick googling showed https://github.com/Skizzk/jquery-pwstrength-bootstrap-rails
#6
Updated by b sh almost 8 years ago
Thanks!
#7
Updated by Daniel Lobato Garcia over 7 years ago
- Pull request https://github.com/theforeman/foreman/pull/1832 added
- Pull request deleted (
)
#8
Updated by The Foreman Bot over 7 years ago
- Status changed from New to Ready For Testing
- Target version set to 1.7.2
#9
Updated by Vanya Jauhal over 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 9f2feee3f395d044f0daffad5950281cce4b74aa.
#10
Updated by Daniel Lobato Garcia over 7 years ago
- Legacy Backlogs Release (now unused) set to 21
Fixes #7587 - Adds client-side password validation