Bug #7588: 'Displaying x entries' button doesn't seem to do anything - Foreman

Actions

Copy link

Bug #7588

closed

'Displaying x entries' button doesn't seem to do anything

Added by Dominic Cleal over 10 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Low

Assignee:

Category:

Web Interface

Target version:

1.7.0

Difficulty:

Triaged:

Bugzilla link:

1145630

Pull request:

https://github.com/theforeman/foreman/pull/1797

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1145630
++ This bug was initially created as a clone of Bug #1145319 ++

Description of problem:
Underneath all of the tables, there's a button that says how many things are in the table and how many are selected. It looks like a button. You can click on it. As far as I can tell, the only thing clicking on it does is add a '#' to the end of the URL. I haven't found a situation where clicking on it ever does anything. If this is simply meant to tell the user how many things are in the table, and how many are selected, it should be plain text. It's misleading to have it look and act like a button, but not do anything.

Am I missing a situation where clicking it changes something?

Version-Release number of selected component (if applicable):
foreman-installer-1.5.0-0.6.RC2.el6ost.noarch
rhel-osp-installer-0.1.10-2.el6ost.noarch
openstack-foreman-installer-2.0.20-1.el6ost.noarch
ruby193-rubygem-staypuft-0.2.5-1.el6ost.noarch

Additional info:

Actions

Copy link

Updated by Dominic Cleal over 10 years ago

Category set to Web Interface
Priority changed from Normal to Low

Actions

Copy link

Updated by b sh over 10 years ago

What about changing the
`content_tag(:li, link_to(html, "#"), :class=>"pull-left")`
into
`content_tag(:li, content_tag(:p, html), :class=>"pull-left")`
@ app/helpers/layout_helper.rb:249

The result is this: http://imgur.com/9r4R5E2

Actions

Copy link