Project

General

Profile

Bug #7588

'Displaying x entries' button doesn't seem to do anything

Added by Dominic Cleal almost 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1145630
++ This bug was initially created as a clone of Bug #1145319 ++

Description of problem:
Underneath all of the tables, there's a button that says how many things are in the table and how many are selected. It looks like a button. You can click on it. As far as I can tell, the only thing clicking on it does is add a '#' to the end of the URL. I haven't found a situation where clicking on it ever does anything. If this is simply meant to tell the user how many things are in the table, and how many are selected, it should be plain text. It's misleading to have it look and act like a button, but not do anything.

Am I missing a situation where clicking it changes something?

Version-Release number of selected component (if applicable):
foreman-installer-1.5.0-0.6.RC2.el6ost.noarch
rhel-osp-installer-0.1.10-2.el6ost.noarch
openstack-foreman-installer-2.0.20-1.el6ost.noarch
ruby193-rubygem-staypuft-0.2.5-1.el6ost.noarch

Additional info:

Associated revisions

Revision a783d2c8 (diff)
Added by B Sh almost 5 years ago

Fixes #7588 - pagination info not a button and aligned

History

#1 Updated by Dominic Cleal almost 5 years ago

  • Category set to Web Interface
  • Priority changed from Normal to Low

#2 Updated by b sh almost 5 years ago

What about changing the
`content_tag(:li, link_to(html, "#"), :class=>"pull-left")`
into
`content_tag(:li, content_tag(:p, html), :class=>"pull-left")`
@ app/helpers/layout_helper.rb:249

The result is this: http://imgur.com/9r4R5E2

#3 Updated by Dominic Cleal almost 5 years ago

Yeah, that's OK. Would be nice if we could keep a border or something too perhaps?

#4 Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Target version set to 1.7.3
  • Pull request https://github.com/theforeman/foreman/pull/1797 added
  • Pull request deleted ()

#5 Updated by Dominic Cleal almost 5 years ago

  • Target version changed from 1.7.3 to 1.7.2

#6 Updated by B Sh almost 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Daniel Lobato Garcia almost 5 years ago

  • Legacy Backlogs Release (now unused) set to 21

Also available in: Atom PDF