Project

General

Profile

Bug #7738

Some SSO methods may fail

Added by Marek Hulán almost 8 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Authentication
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

While we were investigating #7737 we found that we rely on SSO backend to define logout_url. Some of SSO backeds don't define it. Also we need to get into state as if we didn't define it (Base > Apache (defines) > Intercept (undefine) so we should make logout_url returning nil in Base.


Related issues

Related to Foreman - Bug #7737: Change for issue 6999 broke logout for PAM-based (intercept) authenticationClosed2014-09-29

Associated revisions

Revision 5ed22f14 (diff)
Added by Marek Hulán almost 8 years ago

Fixes #7738 - logout_url is nil by default for all SSO backends

Revision 3074ecc1 (diff)
Added by Marek Hulán almost 8 years ago

Fixes #7738 - logout_url is nil by default for all SSO backends

(cherry picked from commit 5ed22f148b7238eef70cc38636cb9bc4624158ef)

History

#1 Updated by Marek Hulán almost 8 years ago

  • Related to Bug #7737: Change for issue 6999 broke logout for PAM-based (intercept) authentication added

#2 Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1808 added
  • Pull request deleted ()

#3 Updated by Marek Hulán almost 8 years ago

I was too fast, try didn't raise it but we'd have two different states there - logout_url returning nil and sso_method.try(:logout_url) returning nil, so I think it's better to be explicit and don't use try.

#4 Updated by Dominic Cleal almost 8 years ago

  • Target version changed from 1.7.3 to 1.7.2

#5 Updated by Marek Hulán almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Daniel Lobato Garcia almost 8 years ago

  • Legacy Backlogs Release (now unused) set to 22

Also available in: Atom PDF