Bug #7738: Some SSO methods may fail - Foreman

Actions

Copy link

Bug #7738

closed

Some SSO methods may fail

Added by Marek Hulán over 10 years ago. Updated almost 7 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marek Hulán

Category:

Authentication

Target version:

1.6.1

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/1808

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

While we were investigating #7737 we found that we rely on SSO backend to define logout_url. Some of SSO backeds don't define it. Also we need to get into state as if we didn't define it (Base > Apache (defines) > Intercept (undefine) so we should make logout_url returning nil in Base.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Marek Hulán over 10 years ago

I was too fast, try didn't raise it but we'd have two different states there - logout_url returning nil and sso_method.try(:logout_url) returning nil, so I think it's better to be explicit and don't use try.