Project

General

Profile

Bug #7750

Foreman - Failed to "Submit" while building a new VM

Added by Dmitry Sakun over 4 years ago. Updated 11 months ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Host creation
Target version:
Difficulty:
easy
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

When you press on Submit button nothing happens.

Error:

"An invalid form control with name='host[mac]' is not focusable"

It looks like it related to the following patch: http://theforeman.org/issues/7560 "Bug #7560: add :required => true on host fields that have conditional validation if host.managed? - Foreman"


Related issues

Related to Foreman - Bug #7560: add :required => true on host fields that have conditional validation if host.managed?Closed2014-09-21
Has duplicate Foreman - Bug #7759: change name of :required => true to :is_required => true since it conflicts with HTML tagDuplicate2014-10-01

Associated revisions

Revision 22438bd2 (diff)
Added by Marek Hulán over 4 years ago

Fixes #7750 - hidden required fields do not prevent submit

When a field is explicitly required an HTML5 tag required was added
which caused issues during form submit.

History

#1 Updated by Dominic Cleal over 4 years ago

  • Related to Bug #7560: add :required => true on host fields that have conditional validation if host.managed? added

#2 Updated by Dominic Cleal over 4 years ago

  • Target version set to 1.7.3

Indeed, when using Chrome and building a host on a compute resource you get an error in the console, but it otherwise fails to submit.

I think Dmitry said that on Firefox it pops up a notification instead.

What appears to be happening is that our "required" flag is actually being passed into the HTML rather than just being used for our "*" markers.

#3 Updated by Dmitry Sakun over 4 years ago

Correct, the error in the description is from Chrome.
In FF I got a strange popup message: "Please fill out this field" in the upper left corner. See attachment

#4 Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1809 added
  • Pull request deleted ()

#5 Updated by Marek Hulán over 4 years ago

  • Assignee set to Marek Hulán

#6 Updated by Dominic Cleal over 4 years ago

  • Target version changed from 1.7.3 to 1.7.2

#7 Updated by Dominic Cleal over 4 years ago

  • Has duplicate Bug #7759: change name of :required => true to :is_required => true since it conflicts with HTML tag added

#8 Updated by Marek Hulán over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF